Prevent an infinite loop in browsers when an error happens in resolve #60
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Whenever an error occurs resolving a component `this.state.error = true`, however handling the error happens too late. As a result in an environment where `typeof window !== 'undefined'` i.e. the browser, this results in an infinite `render` loop. This PR hoists the error handling earlier in the `render` call. Fixes ctrlplusb#42
|
Really excellent stuff here @xzyfer! Thanks so much for this. I am gonna try pull it down and have a play but so far it LGTM. ❤️ |
|
Confirming that this work for me |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Whenever an error occurs resolving a component
this.state.error = true,however handling the error happens too late. As a result in an environment
where
typeof window !== 'undefined'i.e. the browser, this results in aninfinite
renderloop.This PR hoists the error handling earlier in the
rendercall.Fixes #42