net/smc: fix -Wmissing-prototypes warning when CONFIG_SYSCTL not set

Dust Li · kuba-moo · commit d9f509915925 · 2022-03-09T20:02:35.000-08:00
when CONFIG_SYSCTL not set, smc_sysctl_net_init/exit need to be static inline to avoid missing-prototypes if compile with W=1. Since __net_exit has noinline annotation when CONFIG_NET_NS not set, it should not be used with static inline. So remove the __net_init/exit when CONFIG_SYSCTL not set. Fixes: 7de8eb0 ("net/smc: fix compile warning for smc_sysctl") Signed-off-by: Dust Li <dust.li@linux.alibaba.com> Link: https://lore.kernel.org/r/20220309033051.41893-1-dust.li@linux.alibaba.com Signed-off-by: Jakub Kicinski <kuba@kernel.org>
diff --git a/net/smc/smc_sysctl.h b/net/smc/smc_sysctl.h
@@ -20,13 +20,13 @@ void __net_exit smc_sysctl_net_exit(struct net *net);
 
 #else
 
-int __net_init smc_sysctl_net_init(struct net *net)
+static inline int smc_sysctl_net_init(struct net *net)
 {
 	net->smc.sysctl_autocorking_size = SMC_AUTOCORKING_DEFAULT_SIZE;
 	return 0;
 }
 
-void __net_exit smc_sysctl_net_exit(struct net *net) { }
+static inline void smc_sysctl_net_exit(struct net *net) { }
 
 #endif /* CONFIG_SYSCTL */
 

Original file line number	Diff line number	Diff line change
`@@ -20,13 +20,13 @@ void __net_exit smc_sysctl_net_exit(struct net *net);`
`20`	`20`
`21`	`21`	`#else`
`22`	`22`
`23`		`-int __net_init smc_sysctl_net_init(struct net *net)`
	`23`	`+static inline int smc_sysctl_net_init(struct net *net)`
`24`	`24`	`{`
`25`	`25`	`net->smc.sysctl_autocorking_size = SMC_AUTOCORKING_DEFAULT_SIZE;`
`26`	`26`	`return 0;`
`27`	`27`	`}`
`28`	`28`
`29`		`-void __net_exit smc_sysctl_net_exit(struct net *net) { }`
	`29`	`+static inline void smc_sysctl_net_exit(struct net *net) { }`
`30`	`30`
`31`	`31`	`#endif /* CONFIG_SYSCTL */`
`32`	`32`