Skip to content

Commit ca3c6dc

Browse files
Claudio Imbrendahcahca
authored andcommitted
s390/kvm: Remove kvm_arch_fault_in_page()
kvm_arch_fault_in_page() is a useless wrapper around gmap_fault(); just use gmap_fault() directly instead. Signed-off-by: Claudio Imbrenda <imbrenda@linux.ibm.com> Reviewed-by: Janosch Frank <frankja@linux.ibm.com> Link: https://lore.kernel.org/r/20241022120601.167009-3-imbrenda@linux.ibm.com Signed-off-by: Heiko Carstens <hca@linux.ibm.com>
1 parent f96cb0d commit ca3c6dc

File tree

3 files changed

+3
-20
lines changed

3 files changed

+3
-20
lines changed

arch/s390/kvm/intercept.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -367,7 +367,7 @@ static int handle_mvpg_pei(struct kvm_vcpu *vcpu)
367367
reg2, &srcaddr, GACC_FETCH, 0);
368368
if (rc)
369369
return kvm_s390_inject_prog_cond(vcpu, rc);
370-
rc = kvm_arch_fault_in_page(vcpu, srcaddr, 0);
370+
rc = gmap_fault(vcpu->arch.gmap, srcaddr, 0);
371371
if (rc != 0)
372372
return rc;
373373

@@ -376,7 +376,7 @@ static int handle_mvpg_pei(struct kvm_vcpu *vcpu)
376376
reg1, &dstaddr, GACC_STORE, 0);
377377
if (rc)
378378
return kvm_s390_inject_prog_cond(vcpu, rc);
379-
rc = kvm_arch_fault_in_page(vcpu, dstaddr, 1);
379+
rc = gmap_fault(vcpu->arch.gmap, dstaddr, FAULT_FLAG_WRITE);
380380
if (rc != 0)
381381
return rc;
382382

arch/s390/kvm/kvm-s390.c

Lines changed: 1 addition & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -4579,22 +4579,6 @@ int kvm_s390_try_set_tod_clock(struct kvm *kvm, const struct kvm_s390_vm_tod_clo
45794579
return 1;
45804580
}
45814581

4582-
/**
4583-
* kvm_arch_fault_in_page - fault-in guest page if necessary
4584-
* @vcpu: The corresponding virtual cpu
4585-
* @gpa: Guest physical address
4586-
* @writable: Whether the page should be writable or not
4587-
*
4588-
* Make sure that a guest page has been faulted-in on the host.
4589-
*
4590-
* Return: Zero on success, negative error code otherwise.
4591-
*/
4592-
long kvm_arch_fault_in_page(struct kvm_vcpu *vcpu, gpa_t gpa, int writable)
4593-
{
4594-
return gmap_fault(vcpu->arch.gmap, gpa,
4595-
writable ? FAULT_FLAG_WRITE : 0);
4596-
}
4597-
45984582
static void __kvm_inject_pfault_token(struct kvm_vcpu *vcpu, bool start_token,
45994583
unsigned long token)
46004584
{
@@ -4797,7 +4781,7 @@ static int vcpu_post_run(struct kvm_vcpu *vcpu, int exit_reason)
47974781
if (kvm_arch_setup_async_pf(vcpu))
47984782
return 0;
47994783
vcpu->stat.pfault_sync++;
4800-
return kvm_arch_fault_in_page(vcpu, current->thread.gmap_addr, 1);
4784+
return gmap_fault(vcpu->arch.gmap, current->thread.gmap_addr, FAULT_FLAG_WRITE);
48014785
}
48024786
return vcpu_post_run_fault_in_sie(vcpu);
48034787
}

arch/s390/kvm/kvm-s390.h

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -394,7 +394,6 @@ int kvm_s390_handle_sigp_pei(struct kvm_vcpu *vcpu);
394394

395395
/* implemented in kvm-s390.c */
396396
int kvm_s390_try_set_tod_clock(struct kvm *kvm, const struct kvm_s390_vm_tod_clock *gtod);
397-
long kvm_arch_fault_in_page(struct kvm_vcpu *vcpu, gpa_t gpa, int writable);
398397
int kvm_s390_store_status_unloaded(struct kvm_vcpu *vcpu, unsigned long addr);
399398
int kvm_s390_vcpu_store_status(struct kvm_vcpu *vcpu, unsigned long addr);
400399
int kvm_s390_vcpu_start(struct kvm_vcpu *vcpu);

0 commit comments

Comments
 (0)