Skip to content

Commit bd94f35

Browse files
committed
netfilter: nf_tables: fix kdoc warnings after gc rework
JIRA: https://issues.redhat.com/browse/RHEL-1720 JIRA: https://issues.redhat.com/browse/RHEL-1721 Upstream Status: commit 08713cb commit 08713cb Author: Florian Westphal <fw@strlen.de> Date: Thu Aug 10 23:59:03 2023 +0200 netfilter: nf_tables: fix kdoc warnings after gc rework Jakub Kicinski says: We've got some new kdoc warnings here: net/netfilter/nft_set_pipapo.c:1557: warning: Function parameter or member '_set' not described in 'pipapo_gc' net/netfilter/nft_set_pipapo.c:1557: warning: Excess function parameter 'set' description in 'pipapo_gc' include/net/netfilter/nf_tables.h:577: warning: Function parameter or member 'dead' not described in 'nft_set' Fixes: 5f68718 ("netfilter: nf_tables: GC transaction API to avoid race with control plane") Fixes: f6c383b ("netfilter: nf_tables: adapt set backend to use GC transaction API") Reported-by: Jakub Kicinski <kuba@kernel.org> Closes: https://lore.kernel.org/netdev/20230810104638.746e46f1@kernel.org/ Signed-off-by: Florian Westphal <fw@strlen.de> Signed-off-by: Florian Westphal <fwestpha@redhat.com>
1 parent ad6241e commit bd94f35

File tree

2 files changed

+2
-1
lines changed

2 files changed

+2
-1
lines changed

include/net/netfilter/nf_tables.h

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -497,6 +497,7 @@ struct nft_set_elem_expr {
497497
* @expr: stateful expression
498498
* @ops: set ops
499499
* @flags: set flags
500+
* @dead: set will be freed, never cleared
500501
* @genmask: generation mask
501502
* @klen: key length
502503
* @dlen: data length

net/netfilter/nft_set_pipapo.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1550,7 +1550,7 @@ static void nft_pipapo_gc_deactivate(struct net *net, struct nft_set *set,
15501550

15511551
/**
15521552
* pipapo_gc() - Drop expired entries from set, destroy start and end elements
1553-
* @set: nftables API set representation
1553+
* @_set: nftables API set representation
15541554
* @m: Matching data
15551555
*/
15561556
static void pipapo_gc(const struct nft_set *_set, struct nft_pipapo_match *m)

0 commit comments

Comments
 (0)