Skip to content

Commit b9e2faa

Browse files
Hugh Dickinstorvalds
authored andcommitted
huge tmpfs: revert shmem's use of transhuge_vma_enabled()
5.14 commit e6be37b ("mm/huge_memory.c: add missing read-only THP checking in transparent_hugepage_enabled()") added transhuge_vma_enabled() as a wrapper for two very different checks (one check is whether the app has marked its address range not to use THPs, the other check is whether the app is running in a hierarchy that has been marked never to use THPs). shmem_huge_enabled() prefers to show those two checks explicitly, as before. Link: https://lkml.kernel.org/r/45e5338-18d-c6f9-c17e-34f510bc1728@google.com Signed-off-by: Hugh Dickins <hughd@google.com> Reviewed-by: Yang Shi <shy828301@gmail.com> Cc: "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com> Cc: Matthew Wilcox <willy@infradead.org> Cc: Miaohe Lin <linmiaohe@huawei.com> Cc: Michal Hocko <mhocko@suse.com> Cc: Mike Kravetz <mike.kravetz@oracle.com> Cc: Rik van Riel <riel@surriel.com> Cc: Shakeel Butt <shakeelb@google.com> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
1 parent 2b5bbcb commit b9e2faa

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

mm/shmem.c

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3987,7 +3987,8 @@ bool shmem_huge_enabled(struct vm_area_struct *vma)
39873987
loff_t i_size;
39883988
pgoff_t off;
39893989

3990-
if (!transhuge_vma_enabled(vma, vma->vm_flags))
3990+
if ((vma->vm_flags & VM_NOHUGEPAGE) ||
3991+
test_bit(MMF_DISABLE_THP, &vma->vm_mm->flags))
39913992
return false;
39923993
if (shmem_huge == SHMEM_HUGE_FORCE)
39933994
return true;

0 commit comments

Comments
 (0)