Skip to content

Commit 899ef6e

Browse files
committed
USB: remove info() macro from usb input drivers
USB should not be having it's own printk macros, so remove info() and use the system-wide standard of dev_info() wherever possible. Acked-by: Dmitry Torokhov <dmitry.torokhov@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
1 parent 880c9c6 commit 899ef6e

File tree

8 files changed

+23
-14
lines changed

8 files changed

+23
-14
lines changed

drivers/input/joystick/xpad.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -911,7 +911,7 @@ static int __init usb_xpad_init(void)
911911
{
912912
int result = usb_register(&xpad_driver);
913913
if (result == 0)
914-
info(DRIVER_DESC);
914+
printk(KERN_INFO KBUILD_MODNAME ": " DRIVER_DESC "\n");
915915
return result;
916916
}
917917

drivers/input/misc/ati_remote.c

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -834,9 +834,11 @@ static int __init ati_remote_init(void)
834834

835835
result = usb_register(&ati_remote_driver);
836836
if (result)
837-
err("usb_register error #%d\n", result);
837+
printk(KERN_ERR KBUILD_MODNAME
838+
": usb_register error #%d\n", result);
838839
else
839-
info("Registered USB driver " DRIVER_DESC " v. " DRIVER_VERSION);
840+
printk(KERN_INFO KBUILD_MODNAME ": " DRIVER_VERSION ":"
841+
DRIVER_DESC "\n");
840842

841843
return result;
842844
}

drivers/input/misc/yealink.c

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -999,7 +999,8 @@ static int __init yealink_dev_init(void)
999999
{
10001000
int ret = usb_register(&yealink_driver);
10011001
if (ret == 0)
1002-
info(DRIVER_DESC ":" DRIVER_VERSION);
1002+
printk(KERN_INFO KBUILD_MODNAME ": " DRIVER_VERSION ":"
1003+
DRIVER_DESC "\n");
10031004
return ret;
10041005
}
10051006

drivers/input/tablet/acecad.c

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -280,7 +280,8 @@ static int __init usb_acecad_init(void)
280280
{
281281
int result = usb_register(&usb_acecad_driver);
282282
if (result == 0)
283-
info(DRIVER_VERSION ":" DRIVER_DESC);
283+
printk(KERN_INFO KBUILD_MODNAME ": " DRIVER_VERSION ":"
284+
DRIVER_DESC "\n");
284285
return result;
285286
}
286287

drivers/input/tablet/aiptek.c

Lines changed: 8 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1844,16 +1844,18 @@ aiptek_probe(struct usb_interface *intf, const struct usb_device_id *id)
18441844
aiptek->curSetting.programmableDelay = speeds[i];
18451845
(void)aiptek_program_tablet(aiptek);
18461846
if (aiptek->inputdev->absmax[ABS_X] > 0) {
1847-
info("input: Aiptek using %d ms programming speed\n",
1848-
aiptek->curSetting.programmableDelay);
1847+
dev_info(&intf->dev,
1848+
"Aiptek using %d ms programming speed\n",
1849+
aiptek->curSetting.programmableDelay);
18491850
break;
18501851
}
18511852
}
18521853

18531854
/* Murphy says that some day someone will have a tablet that fails the
18541855
above test. That's you, Frederic Rodrigo */
18551856
if (i == ARRAY_SIZE(speeds)) {
1856-
info("input: Aiptek tried all speeds, no sane response");
1857+
dev_info(&intf->dev,
1858+
"Aiptek tried all speeds, no sane response\n");
18571859
goto fail2;
18581860
}
18591861

@@ -1925,8 +1927,9 @@ static int __init aiptek_init(void)
19251927
{
19261928
int result = usb_register(&aiptek_driver);
19271929
if (result == 0) {
1928-
info(DRIVER_VERSION ": " DRIVER_AUTHOR);
1929-
info(DRIVER_DESC);
1930+
printk(KERN_INFO KBUILD_MODNAME ": " DRIVER_VERSION ":"
1931+
DRIVER_DESC "\n");
1932+
printk(KERN_INFO KBUILD_MODNAME ": " DRIVER_AUTHOR "\n");
19301933
}
19311934
return result;
19321935
}

drivers/input/tablet/gtco.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
33
GTCO digitizer USB driver
44
5-
Use the err(), dbg() and info() macros from usb.h for system logging
5+
Use the err() and dbg() macros from usb.h for system logging
66
77
TO CHECK: Is pressure done right on report 5?
88
@@ -1010,7 +1010,7 @@ static void gtco_disconnect(struct usb_interface *interface)
10101010
kfree(gtco);
10111011
}
10121012

1013-
info("gtco driver disconnected");
1013+
dev_info(&interface->dev, "gtco driver disconnected\n");
10141014
}
10151015

10161016
/* STANDARD MODULE LOAD ROUTINES */

drivers/input/tablet/kbtab.c

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -215,7 +215,8 @@ static int __init kbtab_init(void)
215215
retval = usb_register(&kbtab_driver);
216216
if (retval)
217217
goto out;
218-
info(DRIVER_VERSION ":" DRIVER_DESC);
218+
printk(KERN_INFO KBUILD_MODNAME ": " DRIVER_VERSION ":"
219+
DRIVER_DESC "\n");
219220
out:
220221
return retval;
221222
}

drivers/input/tablet/wacom_sys.c

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -385,7 +385,8 @@ static int __init wacom_init(void)
385385
wacom_driver.id_table = get_device_table();
386386
result = usb_register(&wacom_driver);
387387
if (result == 0)
388-
info(DRIVER_VERSION ":" DRIVER_DESC);
388+
printk(KERN_INFO KBUILD_MODNAME ": " DRIVER_VERSION ":"
389+
DRIVER_DESC "\n");
389390
return result;
390391
}
391392

0 commit comments

Comments
 (0)