Skip to content

Commit 851214c

Browse files
committed
net: hsr: Don't log netdev_err message on unknown prp dst node
Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=2177256 commit 28e8cab Author: Kristian Overskeid <koverskeid@gmail.com> Date: Tue Mar 7 14:32:29 2023 +0100 net: hsr: Don't log netdev_err message on unknown prp dst node If no frames has been exchanged with a node for HSR_NODE_FORGET_TIME, the node will be deleted from the node_db list. If a frame is sent to the node after it is deleted, a netdev_err message for each slave interface is produced. This should not happen with dan nodes because of supervision frames, but can happen often with san nodes, which clutters the kernel log. Since the hsr protocol does not support sans, this is only relevant for the prp protocol. Signed-off-by: Kristian Overskeid <koverskeid@gmail.com> Signed-off-by: David S. Miller <davem@davemloft.net> Signed-off-by: Felix Maurer <fmaurer@redhat.com>
1 parent dbff47c commit 851214c

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

net/hsr/hsr_framereg.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -415,7 +415,7 @@ void hsr_addr_subst_dest(struct hsr_node *node_src, struct sk_buff *skb,
415415
node_dst = find_node_by_addr_A(&port->hsr->node_db,
416416
eth_hdr(skb)->h_dest);
417417
if (!node_dst) {
418-
if (net_ratelimit())
418+
if (net_ratelimit() && port->hsr->prot_version != PRP_V1)
419419
netdev_err(skb->dev, "%s: Unknown node\n", __func__);
420420
return;
421421
}

0 commit comments

Comments
 (0)