Skip to content

Commit 6d0ce46

Browse files
edumazetkuba-moo
authored andcommitted
vrf: use RCU protection in l3mdev_l3_out()
l3mdev_l3_out() can be called without RCU being held: raw_sendmsg() ip_push_pending_frames() ip_send_skb() ip_local_out() __ip_local_out() l3mdev_ip_out() Add rcu_read_lock() / rcu_read_unlock() pair to avoid a potential UAF. Fixes: a8e3e1a ("net: l3mdev: Add hook to output path") Signed-off-by: Eric Dumazet <edumazet@google.com> Reviewed-by: David Ahern <dsahern@kernel.org> Reviewed-by: Kuniyuki Iwashima <kuniyu@amazon.com> Link: https://patch.msgid.link/20250207135841.1948589-7-edumazet@google.com Signed-off-by: Jakub Kicinski <kuba@kernel.org>
1 parent 90b2f49 commit 6d0ce46

File tree

1 file changed

+2
-0
lines changed

1 file changed

+2
-0
lines changed

include/net/l3mdev.h

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -198,10 +198,12 @@ struct sk_buff *l3mdev_l3_out(struct sock *sk, struct sk_buff *skb, u16 proto)
198198
if (netif_is_l3_slave(dev)) {
199199
struct net_device *master;
200200

201+
rcu_read_lock();
201202
master = netdev_master_upper_dev_get_rcu(dev);
202203
if (master && master->l3mdev_ops->l3mdev_l3_out)
203204
skb = master->l3mdev_ops->l3mdev_l3_out(master, sk,
204205
skb, proto);
206+
rcu_read_unlock();
205207
}
206208

207209
return skb;

0 commit comments

Comments
 (0)