Skip to content

Commit 69f22c5

Browse files
Hansen Dsouzaalexdeucher
authored andcommitted
drm/amd/display: Add a boot option to reduce phy ssc for HBR3
[Why] Spread on DPREFCLK by 0.3 percent can have a negative effect on sink when PHY SSC is also spread by 0.3 percent [How] Add boot option for DMU to lower PHY SSC Reviewed-by: Nicholas Kazlauskas <nicholas.kazlauskas@amd.com> Signed-off-by: Hansen Dsouza <Hansen.Dsouza@amd.com> Signed-off-by: Tom Chung <chiahsuan.chung@amd.com> Tested-by: Daniel Wheeler <daniel.wheeler@amd.com> Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
1 parent 7a65e88 commit 69f22c5

File tree

3 files changed

+4
-1
lines changed

3 files changed

+4
-1
lines changed

drivers/gpu/drm/amd/display/dmub/dmub_srv.h

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -301,6 +301,7 @@ struct dmub_srv_hw_params {
301301
bool disallow_phy_access;
302302
bool disable_sldo_opt;
303303
bool enable_non_transparent_setconfig;
304+
bool lower_hbr3_phy_ssc;
304305
};
305306

306307
/**

drivers/gpu/drm/amd/display/dmub/inc/dmub_cmd.h

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -694,7 +694,8 @@ union dmub_fw_boot_options {
694694
uint32_t ips_disable: 3; /* options to disable ips support*/
695695
uint32_t ips_sequential_ono: 1; /**< 1 to enable sequential ONO IPS sequence */
696696
uint32_t disable_sldo_opt: 1; /**< 1 to disable SLDO optimizations */
697-
uint32_t reserved : 7; /**< reserved */
697+
uint32_t lower_hbr3_phy_ssc: 1; /**< 1 to lower hbr3 phy ssc to 0.125 percent */
698+
uint32_t reserved : 6; /**< reserved */
698699
} bits; /**< boot bits */
699700
uint32_t all; /**< 32-bit access to bits */
700701
};

drivers/gpu/drm/amd/display/dmub/src/dmub_dcn35.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -426,6 +426,7 @@ void dmub_dcn35_enable_dmub_boot_options(struct dmub_srv *dmub, const struct dmu
426426
boot_options.bits.ips_sequential_ono = params->ips_sequential_ono;
427427
boot_options.bits.disable_sldo_opt = params->disable_sldo_opt;
428428
boot_options.bits.enable_non_transparent_setconfig = params->enable_non_transparent_setconfig;
429+
boot_options.bits.lower_hbr3_phy_ssc = params->lower_hbr3_phy_ssc;
429430

430431
REG_WRITE(DMCUB_SCRATCH14, boot_options.all);
431432
}

0 commit comments

Comments
 (0)