gfs2: Remove unnecessary NULL check before free_percpu()

Chen Ni · Andreas Gruenbacher · commit 4023c3cbc38f · 2025-04-21T18:20:36.000+02:00
free_percpu() checks for NULL pointers internally.
Remove unneeded NULL check here.

Signed-off-by: Chen Ni &lt;nichen@iscas.ac.cn&gt;
Signed-off-by: Andreas Gruenbacher &lt;agruenba@redhat.com&gt;
diff --git a/fs/gfs2/ops_fstype.c b/fs/gfs2/ops_fstype.c
@@ -64,8 +64,7 @@ static void gfs2_tune_init(struct gfs2_tune *gt)
 
 void free_sbd(struct gfs2_sbd *sdp)
 {
-	if (sdp->sd_lkstats)
-		free_percpu(sdp->sd_lkstats);
+	free_percpu(sdp->sd_lkstats);
 	kfree(sdp);
 }
 

Original file line number	Diff line number	Diff line change
`@@ -64,8 +64,7 @@ static void gfs2_tune_init(struct gfs2_tune *gt)`
`64`	`64`
`65`	`65`	`void free_sbd(struct gfs2_sbd *sdp)`
`66`	`66`	`{`
`67`		`- if (sdp->sd_lkstats)`
`68`		`- free_percpu(sdp->sd_lkstats);`
	`67`	`+ free_percpu(sdp->sd_lkstats);`
`69`	`68`	`kfree(sdp);`
`70`	`69`	`}`
`71`	`70`