Skip to content

Commit 2753cc2

Browse files
Anton SalikhmetovChristoph Hellwig
authored andcommitted
hfsplus: over 80 character lines clean-up
Match coding style line length limitation where checkpatch.pl reported over-80-character-line warnings. Signed-off-by: Anton Salikhmetov <alexo@tuxera.com> Signed-off-by: Christoph Hellwig <hch@tuxera.com>
1 parent 596276c commit 2753cc2

File tree

16 files changed

+260
-123
lines changed

16 files changed

+260
-123
lines changed

fs/hfsplus/bfind.c

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,8 @@ int hfs_find_init(struct hfs_btree *tree, struct hfs_find_data *fd)
2222
return -ENOMEM;
2323
fd->search_key = ptr;
2424
fd->key = ptr + tree->max_key_len + 2;
25-
dprint(DBG_BNODE_REFS, "find_init: %d (%p)\n", tree->cnid, __builtin_return_address(0));
25+
dprint(DBG_BNODE_REFS, "find_init: %d (%p)\n",
26+
tree->cnid, __builtin_return_address(0));
2627
mutex_lock(&tree->tree_lock);
2728
return 0;
2829
}
@@ -31,7 +32,8 @@ void hfs_find_exit(struct hfs_find_data *fd)
3132
{
3233
hfs_bnode_put(fd->bnode);
3334
kfree(fd->search_key);
34-
dprint(DBG_BNODE_REFS, "find_exit: %d (%p)\n", fd->tree->cnid, __builtin_return_address(0));
35+
dprint(DBG_BNODE_REFS, "find_exit: %d (%p)\n",
36+
fd->tree->cnid, __builtin_return_address(0));
3537
mutex_unlock(&fd->tree->tree_lock);
3638
fd->tree = NULL;
3739
}

fs/hfsplus/bitmap.c

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,8 @@
1515

1616
#define PAGE_CACHE_BITS (PAGE_CACHE_SIZE * 8)
1717

18-
int hfsplus_block_allocate(struct super_block *sb, u32 size, u32 offset, u32 *max)
18+
int hfsplus_block_allocate(struct super_block *sb, u32 size,
19+
u32 offset, u32 *max)
1920
{
2021
struct hfsplus_sb_info *sbi = HFSPLUS_SB(sb);
2122
struct page *page;

fs/hfsplus/bnode.c

Lines changed: 28 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -212,7 +212,8 @@ void hfs_bnode_move(struct hfs_bnode *node, int dst, int src, int len)
212212
dst_page--;
213213
}
214214
src -= len;
215-
memmove(kmap(*dst_page) + src, kmap(*src_page) + src, len);
215+
memmove(kmap(*dst_page) + src,
216+
kmap(*src_page) + src, len);
216217
kunmap(*src_page);
217218
set_page_dirty(*dst_page);
218219
kunmap(*dst_page);
@@ -250,14 +251,16 @@ void hfs_bnode_move(struct hfs_bnode *node, int dst, int src, int len)
250251

251252
if (src == dst) {
252253
l = min(len, (int)PAGE_CACHE_SIZE - src);
253-
memmove(kmap(*dst_page) + src, kmap(*src_page) + src, l);
254+
memmove(kmap(*dst_page) + src,
255+
kmap(*src_page) + src, l);
254256
kunmap(*src_page);
255257
set_page_dirty(*dst_page);
256258
kunmap(*dst_page);
257259

258260
while ((len -= l) != 0) {
259261
l = min(len, (int)PAGE_CACHE_SIZE);
260-
memmove(kmap(*++dst_page), kmap(*++src_page), l);
262+
memmove(kmap(*++dst_page),
263+
kmap(*++src_page), l);
261264
kunmap(*src_page);
262265
set_page_dirty(*dst_page);
263266
kunmap(*dst_page);
@@ -268,7 +271,8 @@ void hfs_bnode_move(struct hfs_bnode *node, int dst, int src, int len)
268271
do {
269272
src_ptr = kmap(*src_page) + src;
270273
dst_ptr = kmap(*dst_page) + dst;
271-
if (PAGE_CACHE_SIZE - src < PAGE_CACHE_SIZE - dst) {
274+
if (PAGE_CACHE_SIZE - src <
275+
PAGE_CACHE_SIZE - dst) {
272276
l = PAGE_CACHE_SIZE - src;
273277
src = 0;
274278
dst += l;
@@ -340,7 +344,8 @@ void hfs_bnode_unlink(struct hfs_bnode *node)
340344
return;
341345
tmp->next = node->next;
342346
cnid = cpu_to_be32(tmp->next);
343-
hfs_bnode_write(tmp, &cnid, offsetof(struct hfs_bnode_desc, next), 4);
347+
hfs_bnode_write(tmp, &cnid,
348+
offsetof(struct hfs_bnode_desc, next), 4);
344349
hfs_bnode_put(tmp);
345350
} else if (node->type == HFS_NODE_LEAF)
346351
tree->leaf_head = node->next;
@@ -351,7 +356,8 @@ void hfs_bnode_unlink(struct hfs_bnode *node)
351356
return;
352357
tmp->prev = node->prev;
353358
cnid = cpu_to_be32(tmp->prev);
354-
hfs_bnode_write(tmp, &cnid, offsetof(struct hfs_bnode_desc, prev), 4);
359+
hfs_bnode_write(tmp, &cnid,
360+
offsetof(struct hfs_bnode_desc, prev), 4);
355361
hfs_bnode_put(tmp);
356362
} else if (node->type == HFS_NODE_LEAF)
357363
tree->leaf_tail = node->prev;
@@ -379,7 +385,9 @@ struct hfs_bnode *hfs_bnode_findhash(struct hfs_btree *tree, u32 cnid)
379385
struct hfs_bnode *node;
380386

381387
if (cnid >= tree->node_count) {
382-
printk(KERN_ERR "hfs: request for non-existent node %d in B*Tree\n", cnid);
388+
printk(KERN_ERR "hfs: request for non-existent node "
389+
"%d in B*Tree\n",
390+
cnid);
383391
return NULL;
384392
}
385393

@@ -402,7 +410,9 @@ static struct hfs_bnode *__hfs_bnode_create(struct hfs_btree *tree, u32 cnid)
402410
loff_t off;
403411

404412
if (cnid >= tree->node_count) {
405-
printk(KERN_ERR "hfs: request for non-existent node %d in B*Tree\n", cnid);
413+
printk(KERN_ERR "hfs: request for non-existent node "
414+
"%d in B*Tree\n",
415+
cnid);
406416
return NULL;
407417
}
408418

@@ -429,7 +439,8 @@ static struct hfs_bnode *__hfs_bnode_create(struct hfs_btree *tree, u32 cnid)
429439
} else {
430440
spin_unlock(&tree->hash_lock);
431441
kfree(node);
432-
wait_event(node2->lock_wq, !test_bit(HFS_BNODE_NEW, &node2->flags));
442+
wait_event(node2->lock_wq,
443+
!test_bit(HFS_BNODE_NEW, &node2->flags));
433444
return node2;
434445
}
435446
spin_unlock(&tree->hash_lock);
@@ -483,7 +494,8 @@ struct hfs_bnode *hfs_bnode_find(struct hfs_btree *tree, u32 num)
483494
if (node) {
484495
hfs_bnode_get(node);
485496
spin_unlock(&tree->hash_lock);
486-
wait_event(node->lock_wq, !test_bit(HFS_BNODE_NEW, &node->flags));
497+
wait_event(node->lock_wq,
498+
!test_bit(HFS_BNODE_NEW, &node->flags));
487499
if (test_bit(HFS_BNODE_ERROR, &node->flags))
488500
goto node_error;
489501
return node;
@@ -497,7 +509,8 @@ struct hfs_bnode *hfs_bnode_find(struct hfs_btree *tree, u32 num)
497509
if (!test_bit(HFS_BNODE_NEW, &node->flags))
498510
return node;
499511

500-
desc = (struct hfs_bnode_desc *)(kmap(node->page[0]) + node->page_offset);
512+
desc = (struct hfs_bnode_desc *)(kmap(node->page[0]) +
513+
node->page_offset);
501514
node->prev = be32_to_cpu(desc->prev);
502515
node->next = be32_to_cpu(desc->next);
503516
node->num_recs = be16_to_cpu(desc->num_recs);
@@ -607,7 +620,8 @@ void hfs_bnode_get(struct hfs_bnode *node)
607620
if (node) {
608621
atomic_inc(&node->refcnt);
609622
dprint(DBG_BNODE_REFS, "get_node(%d:%d): %d\n",
610-
node->tree->cnid, node->this, atomic_read(&node->refcnt));
623+
node->tree->cnid, node->this,
624+
atomic_read(&node->refcnt));
611625
}
612626
}
613627

@@ -619,7 +633,8 @@ void hfs_bnode_put(struct hfs_bnode *node)
619633
int i;
620634

621635
dprint(DBG_BNODE_REFS, "put_node(%d:%d): %d\n",
622-
node->tree->cnid, node->this, atomic_read(&node->refcnt));
636+
node->tree->cnid, node->this,
637+
atomic_read(&node->refcnt));
623638
BUG_ON(!atomic_read(&node->refcnt));
624639
if (!atomic_dec_and_lock(&node->refcnt, &tree->hash_lock))
625640
return;

fs/hfsplus/brec.c

Lines changed: 18 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,8 @@ u16 hfs_brec_keylen(struct hfs_bnode *node, u16 rec)
3939
!(node->tree->attributes & HFS_TREE_VARIDXKEYS)) {
4040
retval = node->tree->max_key_len + 2;
4141
} else {
42-
recoff = hfs_bnode_read_u16(node, node->tree->node_size - (rec + 1) * 2);
42+
recoff = hfs_bnode_read_u16(node,
43+
node->tree->node_size - (rec + 1) * 2);
4344
if (!recoff)
4445
return 0;
4546

@@ -84,7 +85,8 @@ int hfs_brec_insert(struct hfs_find_data *fd, void *entry, int entry_len)
8485
end_rec_off = tree->node_size - (node->num_recs + 1) * 2;
8586
end_off = hfs_bnode_read_u16(node, end_rec_off);
8687
end_rec_off -= 2;
87-
dprint(DBG_BNODE_MOD, "insert_rec: %d, %d, %d, %d\n", rec, size, end_off, end_rec_off);
88+
dprint(DBG_BNODE_MOD, "insert_rec: %d, %d, %d, %d\n",
89+
rec, size, end_off, end_rec_off);
8890
if (size > end_rec_off - end_off) {
8991
if (new_node)
9092
panic("not enough room!\n");
@@ -99,7 +101,9 @@ int hfs_brec_insert(struct hfs_find_data *fd, void *entry, int entry_len)
99101
}
100102
node->num_recs++;
101103
/* write new last offset */
102-
hfs_bnode_write_u16(node, offsetof(struct hfs_bnode_desc, num_recs), node->num_recs);
104+
hfs_bnode_write_u16(node,
105+
offsetof(struct hfs_bnode_desc, num_recs),
106+
node->num_recs);
103107
hfs_bnode_write_u16(node, end_rec_off, end_off + size);
104108
data_off = end_off;
105109
data_rec_off = end_rec_off + 2;
@@ -151,7 +155,8 @@ int hfs_brec_insert(struct hfs_find_data *fd, void *entry, int entry_len)
151155
if (tree->attributes & HFS_TREE_VARIDXKEYS)
152156
key_len = be16_to_cpu(fd->search_key->key_len) + 2;
153157
else {
154-
fd->search_key->key_len = cpu_to_be16(tree->max_key_len);
158+
fd->search_key->key_len =
159+
cpu_to_be16(tree->max_key_len);
155160
key_len = tree->max_key_len + 2;
156161
}
157162
goto again;
@@ -180,7 +185,8 @@ int hfs_brec_remove(struct hfs_find_data *fd)
180185
mark_inode_dirty(tree->inode);
181186
}
182187
hfs_bnode_dump(node);
183-
dprint(DBG_BNODE_MOD, "remove_rec: %d, %d\n", fd->record, fd->keylength + fd->entrylength);
188+
dprint(DBG_BNODE_MOD, "remove_rec: %d, %d\n",
189+
fd->record, fd->keylength + fd->entrylength);
184190
if (!--node->num_recs) {
185191
hfs_bnode_unlink(node);
186192
if (!node->parent)
@@ -194,7 +200,9 @@ int hfs_brec_remove(struct hfs_find_data *fd)
194200
__hfs_brec_find(node, fd);
195201
goto again;
196202
}
197-
hfs_bnode_write_u16(node, offsetof(struct hfs_bnode_desc, num_recs), node->num_recs);
203+
hfs_bnode_write_u16(node,
204+
offsetof(struct hfs_bnode_desc, num_recs),
205+
node->num_recs);
198206

199207
if (rec_off == end_off)
200208
goto skip;
@@ -364,7 +372,8 @@ static int hfs_brec_update_parent(struct hfs_find_data *fd)
364372
newkeylen = hfs_bnode_read_u16(node, 14) + 2;
365373
else
366374
fd->keylength = newkeylen = tree->max_key_len + 2;
367-
dprint(DBG_BNODE_MOD, "update_rec: %d, %d, %d\n", rec, fd->keylength, newkeylen);
375+
dprint(DBG_BNODE_MOD, "update_rec: %d, %d, %d\n",
376+
rec, fd->keylength, newkeylen);
368377

369378
rec_off = tree->node_size - (rec + 2) * 2;
370379
end_rec_off = tree->node_size - (parent->num_recs + 1) * 2;
@@ -383,7 +392,8 @@ static int hfs_brec_update_parent(struct hfs_find_data *fd)
383392
parent = fd->bnode;
384393
rec = fd->record;
385394
rec_off = tree->node_size - (rec + 2) * 2;
386-
end_rec_off = tree->node_size - (parent->num_recs + 1) * 2;
395+
end_rec_off = tree->node_size -
396+
(parent->num_recs + 1) * 2;
387397
}
388398
}
389399

fs/hfsplus/btree.c

Lines changed: 22 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,8 @@ struct hfs_btree *hfs_btree_open(struct super_block *sb, u32 id)
5151
goto free_inode;
5252

5353
/* Load the header */
54-
head = (struct hfs_btree_header_rec *)(kmap(page) + sizeof(struct hfs_bnode_desc));
54+
head = (struct hfs_btree_header_rec *)(kmap(page) +
55+
sizeof(struct hfs_bnode_desc));
5556
tree->root = be32_to_cpu(head->root);
5657
tree->leaf_count = be32_to_cpu(head->leaf_count);
5758
tree->leaf_head = be32_to_cpu(head->leaf_head);
@@ -115,7 +116,9 @@ struct hfs_btree *hfs_btree_open(struct super_block *sb, u32 id)
115116

116117
tree->node_size_shift = ffs(size) - 1;
117118

118-
tree->pages_per_bnode = (tree->node_size + PAGE_CACHE_SIZE - 1) >> PAGE_CACHE_SHIFT;
119+
tree->pages_per_bnode =
120+
(tree->node_size + PAGE_CACHE_SIZE - 1) >>
121+
PAGE_CACHE_SHIFT;
119122

120123
kunmap(page);
121124
page_cache_release(page);
@@ -144,8 +147,10 @@ void hfs_btree_close(struct hfs_btree *tree)
144147
while ((node = tree->node_hash[i])) {
145148
tree->node_hash[i] = node->next_hash;
146149
if (atomic_read(&node->refcnt))
147-
printk(KERN_CRIT "hfs: node %d:%d still has %d user(s)!\n",
148-
node->tree->cnid, node->this, atomic_read(&node->refcnt));
150+
printk(KERN_CRIT "hfs: node %d:%d "
151+
"still has %d user(s)!\n",
152+
node->tree->cnid, node->this,
153+
atomic_read(&node->refcnt));
149154
hfs_bnode_free(node);
150155
tree->node_hash_cnt--;
151156
}
@@ -166,7 +171,8 @@ void hfs_btree_write(struct hfs_btree *tree)
166171
return;
167172
/* Load the header */
168173
page = node->page[0];
169-
head = (struct hfs_btree_header_rec *)(kmap(page) + sizeof(struct hfs_bnode_desc));
174+
head = (struct hfs_btree_header_rec *)(kmap(page) +
175+
sizeof(struct hfs_bnode_desc));
170176

171177
head->root = cpu_to_be32(tree->root);
172178
head->leaf_count = cpu_to_be32(tree->leaf_count);
@@ -272,7 +278,8 @@ struct hfs_bnode *hfs_bmap_alloc(struct hfs_btree *tree)
272278
tree->free_nodes--;
273279
mark_inode_dirty(tree->inode);
274280
hfs_bnode_put(node);
275-
return hfs_bnode_create(tree, idx);
281+
return hfs_bnode_create(tree,
282+
idx);
276283
}
277284
}
278285
}
@@ -329,15 +336,19 @@ void hfs_bmap_free(struct hfs_bnode *node)
329336
hfs_bnode_put(node);
330337
if (!i) {
331338
/* panic */;
332-
printk(KERN_CRIT "hfs: unable to free bnode %u. bmap not found!\n", node->this);
339+
printk(KERN_CRIT "hfs: unable to free bnode %u. "
340+
"bmap not found!\n",
341+
node->this);
333342
return;
334343
}
335344
node = hfs_bnode_find(tree, i);
336345
if (IS_ERR(node))
337346
return;
338347
if (node->type != HFS_NODE_MAP) {
339348
/* panic */;
340-
printk(KERN_CRIT "hfs: invalid bmap found! (%u,%d)\n", node->this, node->type);
349+
printk(KERN_CRIT "hfs: invalid bmap found! "
350+
"(%u,%d)\n",
351+
node->this, node->type);
341352
hfs_bnode_put(node);
342353
return;
343354
}
@@ -350,7 +361,9 @@ void hfs_bmap_free(struct hfs_bnode *node)
350361
m = 1 << (~nidx & 7);
351362
byte = data[off];
352363
if (!(byte & m)) {
353-
printk(KERN_CRIT "hfs: trying to free free bnode %u(%d)\n", node->this, node->type);
364+
printk(KERN_CRIT "hfs: trying to free free bnode "
365+
"%u(%d)\n",
366+
node->this, node->type);
354367
kunmap(page);
355368
hfs_bnode_put(node);
356369
return;

0 commit comments

Comments
 (0)