Skip to content

Commit 152c133

Browse files
Kemeng Shiakpm00
authored andcommitted
mm: swap: fix potential buffer overflow in setup_clusters()
In setup_swap_map(), we only ensure badpages are in range (0, last_page]. As maxpages might be < last_page, setup_clusters() will encounter a buffer overflow when a badpage is >= maxpages. Only call inc_cluster_info_page() for badpage which is < maxpages to fix the issue. Link: https://lkml.kernel.org/r/20250522122554.12209-4-shikemeng@huaweicloud.com Fixes: b843786 ("mm: swapfile: fix SSD detection with swapfile on btrfs") Signed-off-by: Kemeng Shi <shikemeng@huaweicloud.com> Reviewed-by: Baoquan He <bhe@redhat.com> Cc: Johannes Weiner <hannes@cmpxchg.org> Cc: Kairui Song <kasong@tencent.com> Cc: <stable@vger.kernel.org> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
1 parent 255116c commit 152c133

File tree

1 file changed

+7
-3
lines changed

1 file changed

+7
-3
lines changed

mm/swapfile.c

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3208,9 +3208,13 @@ static struct swap_cluster_info *setup_clusters(struct swap_info_struct *si,
32083208
* and the EOF part of the last cluster.
32093209
*/
32103210
inc_cluster_info_page(si, cluster_info, 0);
3211-
for (i = 0; i < swap_header->info.nr_badpages; i++)
3212-
inc_cluster_info_page(si, cluster_info,
3213-
swap_header->info.badpages[i]);
3211+
for (i = 0; i < swap_header->info.nr_badpages; i++) {
3212+
unsigned int page_nr = swap_header->info.badpages[i];
3213+
3214+
if (page_nr >= maxpages)
3215+
continue;
3216+
inc_cluster_info_page(si, cluster_info, page_nr);
3217+
}
32143218
for (i = maxpages; i < round_up(maxpages, SWAPFILE_CLUSTER); i++)
32153219
inc_cluster_info_page(si, cluster_info, i);
32163220

0 commit comments

Comments
 (0)