Fix :ignore_columns option in "auto_annotate_models" task #298
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ctran
changed the title
ignore_columns option in auto_annotate_models task
Owner
|
It would seem this would benefit from some tests :-). I will still merge if you don't feel like doing that. |
ctran
added a commit
that referenced
this pull request
Dec 2, 2015
Fix :ignore_columns option in "auto_annotate_models" task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the
auto_annotate_modelstask, theignore_columnsoption was always set to"", which causedAnnotateModels.do_annotationsto ignore all columns.