You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
It's right that this is inconsistent, but I'd argue we should remove the nan_to_num from the other IRFs instead of adding it to effective area.
The nans occur when dividing by zero, which always means "no true events in this energy bin". So we just don't know the IRF, filling nan is more appropriate than filling 0.
Effective Area evaluation is missing the application of
numpy.nan_to_num
in the functionseffective_area_per_energy
andeffective_area_per_energy_and_fov
in https://github.com/cta-observatory/pyirf/blob/main/pyirf/irf/effective_area.py unlike for other IRFs.The text was updated successfully, but these errors were encountered: