Fixed a bug of using non-inverse error for weights #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he mean reco directions
jsitarek
requested changes
May 27, 2022
|
Thanks @jsitarek for your check, I overlooked it. The correction is done! |
jsitarek
approved these changes
May 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I was looking into the issue #69, I found that when averaging the telescope-wise reconstructed directions the pipeline uses the errors which are not inverse. This makes the reconstruction performance worse because it weights to the reco parameter whose error is large. I checked that fixing this issue and using the inverse errors improve the angular resolutions, please see the attached two plots for the comparison of the resolutions before and after fixing the bug.
@jsitarek, since it would affect your analysis, please give me an approval when you acknowledge this fix. Thanks!