Setting a nice parameter (the job priority). #264
Conversation
| @@ -4,7 +4,7 @@ | |||
| __all__ = ["slurm_lines", "rc_lines"] | |||
|
|
|||
|
|
|||
| def slurm_lines(queue, job_name, array=None, mem=None, out_name=None): | |||
| def slurm_lines(queue, job_name, array=None, mem=None, out_name=None, nice_parameter=None): | |||
There was a problem hiding this comment.
I'm not sure if None is a 'good' value for this parameter. Maybe the default should be 0 (i.e., no change in priorities). I have to check this but '#SBATCH --nice=None' seems quite anomalous
There was a problem hiding this comment.
In the config file default value is equal 0.
| @@ -20,6 +20,8 @@ def slurm_lines(queue, job_name, array=None, mem=None, out_name=None): | |||
| Requested memory. If None cluster default (5 GB) will be used | |||
| out_name : None or str | |||
| If the output should be written to a specific output file | |||
| nice_parameter : None or int | |||
There was a problem hiding this comment.
Again, maybe there just int (or you should add a line of code later that do something like: 'ok if this is none put it to 0' (but easier to ask only for an int)
| @@ -21,4 +29,6 @@ general: | |||
| nsb: [0.5, 1.0, 1.5, 2.0, 2.5, 3.0] | |||
| env_name: magic-lst # name of the conda environment to be used to process data. | |||
| cluster: "SLURM" # cluster management system on which data are processed. At the moment we have only SLURM available, in the future maybe also condor (PIC, CNAF). | |||
| nice: 0 # Set the job priority >0. A lower nice value increases the priority, while a higher value reduces it. Default value is equal 0. | |||
There was a problem hiding this comment.
Maybe just add that it must be an int, in the range +/- 2147483645 (but only positive values, i.e., lower priority, can be used by standard users)
magicctapipe/scripts/lst1_magic/semi_automatic_scripts/clusters.py
Outdated
Show resolved
Hide resolved
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #264 +/- ##
=======================================
Coverage 77.23% 77.23%
=======================================
Files 21 21
Lines 2614 2614
=======================================
Hits 2019 2019
Misses 595 595 ☔ View full report in Codecov by Sentry. |
No description provided.