Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gammaboard: Labels aren't printed #181

Open
mikael10j opened this issue Apr 8, 2022 · 3 comments
Open

Gammaboard: Labels aren't printed #181

mikael10j opened this issue Apr 8, 2022 · 3 comments
Assignees
Labels
bug Something isn't working

Comments

@mikael10j
Copy link
Collaborator

Gammaboard labels aren't printed until we select a reference curve.

@mikael10j mikael10j self-assigned this Apr 8, 2022
@mikael10j
Copy link
Collaborator Author

@vuillaut is there any reason why ax.legend() isn't called in some ctaplot.plots functions ?

@mikael10j mikael10j added the bug Something isn't working label Apr 8, 2022
@mikael10j mikael10j changed the title Gammaboard: Label aren't printed Gammaboard: Labels aren't printed Apr 8, 2022
@vuillaut
Copy link
Member

@vuillaut is there any reason why ax.legend() isn't called in some ctaplot.plots functions ?

In generic functions such as plot_angular_resolution_per_energy for example?
I think the rational was not to call legend() by default because no label is provided by default (that would raise a warning if no label is provided).
If the user (here gammaboard) provides a label, I believe he could also call legend()...
Or we could have an if condition in each plotting function...

@mikael10j
Copy link
Collaborator Author

Ok, thank you, understood. Let's call it in gammaboard.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants