Skip to content

msg-filter: tweak path substitution for RHIVOS kernels #224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 8, 2025

Conversation

kdudka
Copy link
Member

@kdudka kdudka commented Apr 7, 2025

... that use the el9_6iv dist tag. The regex we have been using did not accept the iv suffix.

Reported-by: Erico Nunes

... that use the `el9_6iv` dist tag.  The regex we have been using
did not accept the `iv` suffix.

Reported-by: Erico Nunes
Closes: csutils#224
@kdudka kdudka requested a review from sfowl April 7, 2025 13:16
@kdudka kdudka self-assigned this Apr 7, 2025
@kdudka
Copy link
Member Author

kdudka commented Apr 7, 2025

/packit rebuild-failed

Copy link

@sfowl sfowl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

FWIW, looking at some internal data, suffixes like "el8_9.1" also seem somewhat common. Here's a few examples:

 autofs-5.1.4-109.el8_9.1
 avahi-0.7-21.el8_9.1
 bind-9.11.36-11.el8_9.1
 bind9.16-9.16.23-0.16.el8_9.2
 c-ares-1.13.0-9.el8_9.1

@kdudka
Copy link
Member Author

kdudka commented Apr 8, 2025

Yes, this is the recommended versioning of Z-stream updates. These suffixes do not appear in file paths in scan results though. For example, if you look at the scan results of curl-8.12.1-1.el10 and curl-8.12.1-1.el10_0.1, the top-level directory is curl-8.12.1 in both the cases. So these results can be easily matched with each other without any transformation. The regex we are patching in this pull request is mostly used for Z-stream kernel builds, which use a very specific directory structure, as described in the commit message of f05aa13.

@kdudka kdudka closed this in 8c15ef8 Apr 8, 2025
@kdudka kdudka merged commit 8c15ef8 into csutils:main Apr 8, 2025
36 checks passed
@kdudka kdudka deleted the kernel-iv branch April 8, 2025 06:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants