fixup! csfilter-kfp: script to filter known false positives

Author: kdudka

src/csfilter-kfp

@@ -69,8 +69,9 @@ def construct_prep_cmd(args):
         # clone git repo
         cmd = construct_git_cmd(args.kfp_git_url)
     elif args.kfp_dir:
-        # symlink a directory
-        cmd = f'ln -s "{args.kfp_dir}" "${{td}}/kfp"\n'
+        # symlink an absolute path to the directory
+        kfp_abs = os.path.realpath(args.kfp_dir)
+        cmd = f'ln -s "{kfp_abs}" "${{td}}/kfp"\n'
     elif os.path.isfile(DEFAULT_KFP_JSON):
         # create symlinks to the known-false-positives RPM package installed on the system
         cmd = f'ln -s "{DEFAULT_KFP_DIR}" "${{td}}/kfp"\n' \
@@ -204,12 +205,8 @@ def main():
     args = parser.parse_args()
 
     # if --kfp-dir is used, check that a directory was given
-    if args.kfp_dir:
-        if not os.path.isdir(args.kfp_dir):
-            parser.error(f"'{args.kfp_dir}' given to --kfp-dir is not a directory")
-
-        # get rid of relative paths
-        args.kfp_dir = os.path.realpath(args.kfp_dir)
+    if args.kfp_dir and not os.path.isdir(args.kfp_dir):
+        parser.error(f"'{args.kfp_dir}' given to --kfp-dir is not a directory")
 
     # construct the command to filter
     try: