writer-json: always write the results property in SARIF

The property is strictly required by GitHub.

Fixes: #102
Closes: #104

Author: kdudka

src/lib/writer-json.cc

@@ -433,9 +433,8 @@ void SarifTreeEncoder::writeTo(std::ostream &str)
     PTree run0;
     run0.put_child("tool", tool);
 
-    if (!results_.empty())
-        // results
-        run0.put_child("results", results_);
+    // results
+    run0.put_child("results", results_);
 
     // mandatory: runs
     PTree runs;

tests/csgrep/0108-sarif-empty-results-args.txt

@@ -0,0 +1 @@
+--mode=sarif

tests/csgrep/0108-sarif-empty-results-stdin.txt

@@ -0,0 +1,22 @@
+{
+    "$schema": "https://json.schemastore.org/sarif-2.1.0.json",
+    "version": "2.1.0",
+    "inlineExternalProperties": [
+        {
+            "externalizedProperties": {
+                "tool": "vcs-diff-lint",
+                "tool-url": "https://github.com/fedora-copr/vcs-diff-lint#readme"
+            }
+        }
+    ],
+    "runs": [
+        {
+            "tool": {
+                "driver": {
+                    "name": "vcs-diff-lint",
+                    "informationUri": "https://github.com/fedora-copr/vcs-diff-lint#readme"
+                }
+            }
+        }
+    ]
+}

tests/csgrep/0108-sarif-empty-results-stdout.txt

@@ -0,0 +1,23 @@
+{
+    "$schema": "https://json.schemastore.org/sarif-2.1.0.json",
+    "version": "",
+    "inlineExternalProperties": [
+        {
+            "externalizedProperties": {
+                "tool": "vcs-diff-lint",
+                "tool-url": "https://github.com/fedora-copr/vcs-diff-lint#readme"
+            }
+        }
+    ],
+    "runs": [
+        {
+            "tool": {
+                "driver": {
+                    "name": "vcs-diff-lint",
+                    "informationUri": "https://github.com/fedora-copr/vcs-diff-lint#readme"
+                }
+            },
+            "results": ""
+        }
+    ]
+}

tests/csgrep/CMakeLists.txt

@@ -148,3 +148,4 @@ test_csgrep("0101-json-parser-empty"                  )
 test_csgrep("0102-xml-parser-empty"                   )
 test_csgrep("0106-snyk-prepend-path"                  )
 test_csgrep("0107-gcc-prepend-path"                   )
+test_csgrep("0108-sarif-empty-results"                )