Skip to content

Commit 10afff8

Browse files
committed
fixup! json-{sarif,simple}: propagate endLine/endColumn
1 parent b67c44f commit 10afff8

File tree

2 files changed

+9
-6
lines changed

2 files changed

+9
-6
lines changed

src/lib/defect.hh

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -55,8 +55,9 @@ struct DefEvent {
5555
/// 0 = key event, 1 = info event, 2 = trace event
5656
int verbosityLevel = 0;
5757

58-
short hSize = 0; //< endColumn - startColumn
59-
short vSize = 0; //< endLine - startLine
58+
using TNumDiff = unsigned short;
59+
TNumDiff hSize = 0; //< endColumn - startColumn
60+
TNumDiff vSize = 0; //< endLine - startLine
6061

6162
DefEvent() { }
6263

@@ -67,10 +68,10 @@ struct DefEvent {
6768
};
6869

6970
///< return (end - beg) if it is positive and fits into `short`, 0 otherwise
70-
inline short diffNums(const int beg, const int end)
71+
inline DefEvent::TNumDiff diffNums(const int beg, const int end)
7172
{
7273
const int diff = end - beg;
73-
return (0 < diff && diff < std::numeric_limits<short>::max())
74+
return (0 < diff && diff < std::numeric_limits<DefEvent::TNumDiff>::max())
7475
? diff
7576
: 0;
7677
}

src/lib/parser-json-simple.cc

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -136,15 +136,17 @@ bool SimpleTreeDecoder::readNode(Defect *def)
136136
TEvtList &evtListDst = def->events;
137137
const pt::ptree &evtListSrc = defNode.get_child("events");
138138
for (const pt::ptree::value_type &evtItem : evtListSrc) {
139+
using TNumDiff = DefEvent::TNumDiff;
140+
139141
const pt::ptree &evtNode = evtItem.second;
140142
d->reportUnknownNodes(Private::NK_EVENT, evtNode);
141143

142144
DefEvent evt;
143145
evt.fileName = valueOf<std::string >(evtNode, "file_name");
144146
evt.line = valueOf<int >(evtNode, "line");
145147
evt.column = valueOf<int >(evtNode, "column");
146-
evt.hSize = valueOf<short >(evtNode, "h_size");
147-
evt.vSize = valueOf<short >(evtNode, "v_size");
148+
evt.hSize = valueOf<TNumDiff >(evtNode, "h_size");
149+
evt.vSize = valueOf<TNumDiff >(evtNode, "v_size");
148150
evt.event = valueOf<std::string >(evtNode, "event");
149151
evt.msg = valueOf<std::string >(evtNode, "message");
150152
evt.verbosityLevel = valueOf<int>(evtNode, "verbosity_level", -1);

0 commit comments

Comments
 (0)