Add support for CSSStyleSheet instance in DomRenderer for CSP enabled applications without relying on nonce #1666
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request introduces support for using a
CSSStyleSheetinstance provided by the user in theDomRendererclass. This enhancement is aimed at improving the flexibility and security of style injection in Content Security Policy (CSP) enabled applications. While maintaining support for nonce, it also provides an alternative for environments where the nonce value is not exposed.Problem
In CSP enabled applications, inline styles are often restricted, making it challenging to manage stylesheets securely. The current implementation of JSS supports nonce for CSP, but it does not support the direct use of a
CSSStyleSheetinstance created and managed outside of JSS. This limitation hinders the ability to inject styles into a secureCSSStyleSheet, especially in environments where the nonce value is not exposed.Solution
The proposed solution allows users to provide a
CSSStyleSheetinstance as theinsertionPointin theDomRendererclass. The changes include:DomRendererto accept aCSSStyleSheetinstance.insertStylemethod to handleCSSStyleSheetinstances.Changes
DomRendererconstructor to check ifinsertionPointis an instance ofCSSStyleSheetand use it directly if true.insertStylemethod to insert rules into the providedCSSStyleSheetinstance.Impact
This change enhances the security and flexibility of JSS by allowing styles to be injected into a
CSSStyleSheetinstance, which is particularly useful in CSP enabled environments. It ensures that JSS can be used in a wider range of applications with strict security policies, even when the nonce value is not exposed.Testing
The changes have been tested in a CSP enabled environment to ensure that styles are correctly injected into the provided
CSSStyleSheetinstance without violating CSP rules.Corresponding Issue(s):
What Would You Like to Add/Fix?
Todo
Expectations on Changes
Changelog