Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[jss-isolate] improve API, so plugin could accept multiple configs #699

Open
5 tasks
yakhinvadim opened this issue Apr 13, 2018 · 1 comment
Open
5 tasks
Labels
complexity:moderate We talked about it, you can do it! feature request This will safe many lifes!

Comments

@yakhinvadim
Copy link

yakhinvadim commented Apr 13, 2018

Motivation

See #698 (comment)

TODO

  • Decide, should we introduce new 'non-inherited' keyword for reset property
  • Decide, how new API should work
  • Write tests
  • Implement new API
  • Update readme
@yakhinvadim
Copy link
Author

Right now in order to implement the behavior I described in Motivation section, we'd need to merge two configs:

// 1
jss.use(
  isolate({
    isolate: 'root',
    reset:  'all' // or just 'inherited', because 'non-inherited' part is covered in second config
  })
);

// 2
jss.use(
  isolate({
    reset: 'non-inherited'
  })
);

The first questions is: is it OK to introduce new 'non-inherited' keyword for this use-case?

@kof kof added feature request This will safe many lifes! complexity:moderate We talked about it, you can do it! labels Apr 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
complexity:moderate We talked about it, you can do it! feature request This will safe many lifes!
Projects
None yet
Development

No branches or pull requests

2 participants