Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[jss-default-unit] maintain unitless and non-px props instead #687

Open
1 task
kof opened this issue Feb 24, 2018 · 0 comments
Open
1 task

[jss-default-unit] maintain unitless and non-px props instead #687

kof opened this issue Feb 24, 2018 · 0 comments
Labels
complexity:moderate We talked about it, you can do it! enhancement No kittens die if we don't do that. plugin When unplugged is fine

Comments

@kof
Copy link
Member

kof commented Feb 24, 2018 •
edited
Loading

Currently we maintain many specific props for default px units. It would be easier to maintain only unitless and non-px values, so that the list is shorter.

Ideally we should generate them from mdn data like we do for the vendor prefixer.
@kof kof added enhancement No kittens die if we don't do that. complexity:moderate We talked about it, you can do it! labels Feb 24, 2018
@kof kof changed the title [jss-default-unit] maintain unitless and non-px props [jss-default-unit] maintain unitless and non-px props instead Feb 24, 2018
@kof kof added the plugin When unplugged is fine label Mar 19, 2018
@kof kof mentioned this issue May 3, 2018
Closed
@kof kof mentioned this issue Sep 24, 2018
Closed
@kof kof mentioned this issue Oct 12, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
complexity:moderate We talked about it, you can do it! enhancement No kittens die if we don't do that. plugin When unplugged is fine
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kof