fix(tatakforms): can scan student from another department

Author: mavyfaby

src/db/models/college.ts

@@ -87,6 +87,42 @@ class College {
     });
   }
 
+  /**
+   * Get college by id
+   */
+  public static getById(id: number): Promise<CollegeModel> {
+    return new Promise(async (resolve, reject) => {
+      // Get database instance
+      const db = Database.getInstance();
+
+      try {
+        // Get college by acronym
+        const college = await db.query<CollegeModel[]>(`SELECT * FROM colleges WHERE disabled = 0 AND id = ? LIMIT 1`, [id]);
+
+        // If no results
+        if (college.length === 0) {
+          Log.e(`College with id ${id} not found`);
+          return reject(`College with id ${id} not found`);
+
+        }
+        
+        // Get all courses
+        const courses = await db.query<CourseModel[]>(`SELECT * FROM colleges_courses WHERE college_id = ?`, [college[0].id]);
+        // Set the courses to the college
+        college[0].courses = courses;
+
+        // Return the college
+        resolve(college[0]);
+      }
+      
+      // Log error and reject promise
+      catch (e) {
+        Log.e(e);
+        reject(ErrorTypes.DB_ERROR);
+      }
+    });
+  }
+
   /**
    * Get college by acronym
    * @param acronym 

src/db/models/tatakform/attendance.ts

@@ -4,6 +4,8 @@ import { AttendanceModel, TatakformModel } from "../../../types/models";
 import Database from "../..";
 import Log from "../../../utils/log";
 import Tatakform from "./tatakform";
+import TatakFormStudent from "./student";
+import College from "../college";
 
 enum Days {
   DAY1AM = "day1_am",
@@ -31,22 +33,33 @@ class TatakFormAttendance {
    */
   public static attendStudent(data: { studentId: string, dateStamp: string, collegeId: number, event: TatakformModel }) {
     return new Promise(async (resolve, reject) => {
-      // Get database instance
-      const db = Database.getInstance();
-      // Get column name
-      const columnName = TatakFormAttendance.getCurrentDay(data.event, data.dateStamp);
-      
-      // Switch column name
-      switch(columnName) {
-        case EventStatus.NOT_ACCEPTING:
-          return reject("Event is not accepting attendance.");
-        case EventStatus.NOT_YET_OPEN:
-          return reject("Event is not yet open.");
-        case EventStatus.ALREADY_CLOSED:
-          return reject("Event is already closed.");
-      }
-        
       try {
+        // Get column name
+        const columnName = TatakFormAttendance.getCurrentDay(data.event, data.dateStamp);
+        
+        // Switch column name
+        switch(columnName) {
+          case EventStatus.NOT_ACCEPTING:
+            return reject("Event is not accepting attendance.");
+          case EventStatus.NOT_YET_OPEN:
+            return reject("Event is not yet open.");
+          case EventStatus.ALREADY_CLOSED:
+            return reject("Event is already closed.");
+        }
+
+        // Get student's college data
+        const college = await TatakFormStudent.getCollegeFromStudentId(data.studentId);
+
+        // If not synced
+        if (college.id !== data.collegeId) {
+          // Get college from college id
+          const c = await College.getById(data.collegeId);
+          // Reject promise
+          return reject(`Student is not part of ${c.name} college/department.`);
+        }
+
+        // Get database instance
+        const db = Database.getInstance();
         // Query
         let query = "";
 

src/db/models/tatakform/student.ts

@@ -1,4 +1,4 @@
-import type { TatakformStudent, UnivStudentModel } from "../../../types/models";
+import type { CollegeModel, TatakformStudent, UnivStudentModel } from "../../../types/models";
 import type { MariaUpdateResult } from "../../../types";
 
 import { PaginationOutput } from "../../../types/request";
@@ -14,6 +14,7 @@ import Database from "../..";
 import Log from "../../../utils/log";
 import Strings from "../../../config/strings";
 import Config from "../../../config";
+import College from "../college";
 
 /**
  * TatakForm Student model
@@ -377,6 +378,43 @@ class TatakFormStudent {
     });
   }
 
+  /**
+   * Get college from student id
+   */
+  public static getCollegeFromStudentId(student_id: string): Promise<CollegeModel> {
+    return new Promise(async (resolve, reject) => {
+      // Get database instance
+      const db = Database.getInstance();
+
+      try {
+        // Get colleges
+        const colleges = await College.getAll();
+        // Get student
+        const student = await TatakFormStudent.getByStudentId(student_id);
+
+        // Find college
+        for (const college of colleges) {
+          if (!college.courses) continue;
+
+          for (const course of college.courses) {
+            if (course.id === student.course_id) {
+              return resolve(college);
+            }
+          }
+        }
+        
+        // If not found
+        reject("College not found");
+      }
+      
+      // Log error and reject promise
+      catch (e) {
+        Log.e(e);
+        reject(e);
+      }
+    });
+  }
+
   /**
    * Check whether a student exists
    * @param key Student column