Profile

[neonstalwart]

action is ignored in profile afaik

[neonstalwart]

the sed at the end of build.sh spits out some error for me and i didn't update the args for building with java

[neonstalwart]

aargh... ignore this pull request - i need to go to bed. we need to start over but maybe we can have a little discussion first.

for some reason i was confused and thought that profiles/main.profile.js was coming into play in the build. this is not the case in the amd1.7-wip branch so ignore my comment about action being ignored.

i now see that your intent was to use --package to pick up src/js/app/package.json and then based on the dojoBuild property, app.profile.js would be used as a build profile. this is not happening. it seems that this is to be expected but it would help if @rcgill (rawld if you're following, we're talking about code on the amd1.7-wip branch) could confirm.

http://livedocs.dojotoolkit.org/build/buildSystem#package-json-resources shows that package.json resources (specified via --package) only contribute a single package config to the packages configuration and don't affect any other part of the config. this is why you weren't seeing any layers or buildPath config coming from src/js/app/app.profile.js

it seems there is a distinction between what i'll call a "resource profile" (src/js/app/app.profile.js) and a "build profile" (profiles/main.profile.js). since it seems to me these do not do the same thing we should probably look at using a different naming convention for the resource profile - app.resource.js perhaps? again, maybe @rcgill could give some guidance here about why they are both named as .profile.js and perhaps they are capable of serving a dual purpose.

the simple solution is to use --profile with the appropriate value (i think this is what is in amd1.7) rather than --package but i think you already knew that.

@csnover i'm closing this for now but feel free to continue the discussion here or elsewhere.

[rcgill]

@neonstalwart is correct. The profile referenced via the dojoBuild property in package.json should be used to specify typically-static properties that pertain to that package only. The two most important use cases are

1. defining resourceTags
2. defining required resource tree, dirs, and files that a particular package may need during the build that are separate from then package location.

Note that these can not be specified directly in the package.json because their types are often not valid JSON.

These properties don't change from build-to-build and a user shouldn't have to worry about them...they are the responsibility of the package developer, not the package user.