This repository has been archived by the owner on Dec 31, 2017. It is now read-only.
Converting dbp/Router to AMD #27
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not necessary due to |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was up late for some reason and figured "Hey, I'll take a crack at converting the dbp Router to AMD, yay".
I've replaced the various
dojo.fooandd.foocalls with their various more granular counterparts in a way that seems appropriate. I've also updated the test harness kickoff page, and in running the tests that existed, everything was happy.It's worth noting that I didn't update
dbp/tests/Router.jsas I haven't done much with DOH in AMD yet - just the Router itself.