Add Windows support + bugs fixes #47
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cslarsen
requested changes
Sep 18, 2019
Owner
cslarsen
left a comment
cslarsen
left a comment
There was a problem hiding this comment.
Sorry for the long wait, but if you fix these I will pull the PR.
| game[0] = 1 + race | ||
| writer.writerow(game) | ||
|
|
||
| if os.path.exists(filename): |
Owner
There was a problem hiding this comment.
Please remove this or put into another PR
| tag = result[-1] | ||
| games[tag].append(result[:-1]) | ||
| current_tag = tag | ||
| if len(row) == 9: |
| def set_colors(self): | ||
| """Sets up curses color pairs.""" | ||
| hicolor = os.getenv("TERM").endswith("256color") | ||
| hicolor = os.getenv("TERM").endswith("256color") if os.getenv("TERM") else None |
Owner
There was a problem hiding this comment.
Suggested change
| hicolor = os.getenv("TERM").endswith("256color") if os.getenv("TERM") else None | |
| hicolor = os.getenv("TERM", "").endswith("256color") |
| """Characters per second.""" | ||
| if self.start is None: | ||
| return 0 | ||
| if not elapsed: |
Owner
There was a problem hiding this comment.
I see why you do this, but I'd prefer to have it in a separate PR.
| if self.start is None: | ||
| return 0 | ||
| if not elapsed: | ||
| return 0 |
Owner
There was a problem hiding this comment.
Please put in another PR, this is unrelated to windows support.
| name="wpm", | ||
| scripts=["scripts/wpm"], | ||
| entry_points = { | ||
| "console_scripts": ['wpm = wpm.commandline:main'] |
Owner
There was a problem hiding this comment.
Will entry_points interfere with non-Windows systems?
| """ | ||
|
|
||
| import os | ||
| import sys |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using the recommended approach for calling the main script (which supports windows).
Fix some bugs that arose when testing on native Windows, Python 3.7.