added dockerfiles for the remaining langs #32
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @roerohan, can you please review this? Made quite a few changes, and wanted to get a review before merging. |
roerohan
suggested changes
Oct 1, 2020
roerohan
approved these changes
Oct 1, 2020
This was
linked to
issues
Oct 1, 2020
roerohan
changed the title
This was referenced Oct 1, 2020
roerohan
added a commit
that referenced
this pull request
Oct 1, 2020
* fix: -f flag added to npm clean script, prevents failure if ./dist does not exist * feat: v0.1.8 * WIP: added dockerfiles for the remaining langs (#32) * feat: accepting only suported languages * feat: added dockerfiles for the remaining langs * fix: trimming outputs before comparing * fix: error handling got worker.build() * feat: better error handling, closes #18 and #14 * feat: added log for error * feat: v0.1.9 Co-authored-by: Rahil Kabani <rahil.kabani.4@gmail.com>
roerohan
added a commit
that referenced
this pull request
Oct 1, 2020
* fix: -f flag added to npm clean script, prevents failure if ./dist does not exist * feat: v0.1.8 * WIP: added dockerfiles for the remaining langs (#32) * feat: accepting only suported languages * feat: added dockerfiles for the remaining langs * fix: trimming outputs before comparing * fix: error handling got worker.build() * feat: better error handling, closes #18 and #14 * feat: added log for error * feat: v0.1.9 * feat: v0.2.0 [BREAKING CHANGE] (#34) * refactor: [BREAKING CHANGE] changed default import to { CodeExecutor } * docs: [BREAKING CHANGE] default import to { CodeExecutor } * fix: Build only python and bash * docs: worker.build builds all languages by default * feat: v0.2.0 [BREAKING CHANGE] Co-authored-by: Rahil Kabani <rahil.kabani.4@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not merge yet. I am also doing some error handling for the worker class in the same PR.
Edit: closes #18 and #14.