Skip to content

Fix parsing form file reflection error #383

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 10, 2023

Conversation

angary
Copy link
Member

@angary angary commented Sep 8, 2023

Originally there as an error parsing uploaded image requests. This is because field.Type().Name() returns a string of the field type and so an error was thrown from trying to read a non-existing file from the request.

Correcting this to v.Type().Field(i).Name changes it to a string of the field name.

@angary angary requested a review from ShunyaoLiang as a code owner September 8, 2023 07:12
@angary angary changed the title Fix reflection error Fix parsing form file reflection error Sep 8, 2023
Copy link
Contributor

@ShunyaoLiang ShunyaoLiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Straightforward. Love it

@ShunyaoLiang ShunyaoLiang merged commit b26e913 into csesoc:main Sep 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants