Skip to content

Fix navbar links #219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 28, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions frontend/src/App.vue
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
<template>
<v-app id="main-app">
<Navbar />
<v-main class="pa-0">
<Menu v-if="showMenu" @shown="onMenuCollapse" />
<RouterView style="overflow-x: hidden" />
Expand All @@ -12,7 +11,7 @@
<script>
import Footer from '@/components/Footer';
import Menu from '@/components/Menu';
import Navbar from '@/components/Navbar';
// import Navbar from '@/components/Navbar';

export default {
name: 'App',
Expand All @@ -22,7 +21,7 @@ export default {
components: {
Footer,
Menu,
Navbar,
// Navbar,
},
methods: {
onMenuCollapse(val) {
Expand Down
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
<!--
Navbar
PrimaryNavbar
--
This component is static on the top of the page and displays links to different parts
the screen
This component is static on the top of Home page and links to different parts of the screen.
Also links to the Sponsorship page.
-->

<template>
Expand Down Expand Up @@ -92,7 +92,7 @@

<script type="text/javascript">
export default {
name: 'Navbar',
name: 'PrimaryNavbar',
methods: {
goto(refName) {
const element = document.getElementById(refName);
Expand Down
63 changes: 63 additions & 0 deletions frontend/src/components/SecondaryNavbar.vue
Original file line number Diff line number Diff line change
@@ -0,0 +1,63 @@
<!--
SecondaryNavbar
--
This component is static on the top of the About and Sponsorship pages. It links to
each one and the home `/` page.
-->

<template>
<v-app-bar app color="rgba(0,0,51,0.9)" elevation="0" width="100vw">
<!-- Large screen display -->
<v-container class="hidden-sm-and-down">
<v-row class="d-flex">
<v-col class="d-flex ps-10 align-center justify-start">
<RouterLink to="/" style="text-decoration: none;" v-on:click.native="showMenu = false">
<v-img contain max-height="60px" max-width="100px" src="@/assets/csesocwhiteblue.png" />
</RouterLink>
</v-col>
<v-col class="d-flex align-center justify-end pr-10">
<v-btn text to='/about' class="mr-2" color="white">ABOUT US</v-btn>
<v-btn text to="/sponsors" class="ms-2" color="white">SPONSORSHIP</v-btn>
</v-col>
</v-row>
</v-container>

<!-- Smaller screen container -->
<v-container class="hidden-md-and-up">
<v-row class="d-flex justify-space-between">
<v-col class="d-flex align-center">
<RouterLink to="/" style="text-decoration: none;" v-on:click.native="showMenu = false">
<v-img contain max-height="40px" max-width="100px" src="@/assets/csesocwhiteblue.png" />
</RouterLink>
</v-col>
<v-col class="d-flex justify-end">
<v-menu bottom left>
<template v-slot:activator="{ on, attrs }">
<v-btn dark icon v-bind="attrs" v-on="on">
<v-icon>mdi-menu</v-icon>
</v-btn>
</template>
<v-list>
<v-list-item>
<RouterLink to="/about" style="text-decoration: none; color: black;">
About us
</RouterLink>
</v-list-item>
<v-list-item>
<RouterLink style="text-decoration: none; color: black;" to="/sponsors">
Sponsorship
</RouterLink>
</v-list-item>
</v-list>
</v-menu>
</v-col>
</v-row>
</v-container>
</v-app-bar>
</template>

<script type="text/javascript">
export default {
name: 'SecondaryNavbar',
};
</script>
5 changes: 4 additions & 1 deletion frontend/src/views/About.vue
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@

<template>
<v-app>
<SecondaryNavbar />
<v-parallax height="300" src="../assets/fade.png"></v-parallax>
<!-- About -->
<v-container ref="content-start" style="padding: 0px 30px 10px 30px">
Expand Down Expand Up @@ -317,6 +318,7 @@

<script>
import HeaderTitle from '@/components/HeaderTitle';
import SecondaryNavbar from '../components/SecondaryNavbar';

const fs = require('@/assets/execs_directs.json');

Expand All @@ -326,7 +328,8 @@ export default {
execsDirects: fs
}),
components: {
HeaderTitle
HeaderTitle,
SecondaryNavbar
}
};
</script>
Expand Down
5 changes: 4 additions & 1 deletion frontend/src/views/Home/AboutUs.vue
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
</v-col>
<v-col xs="12" sm="6" align-self="center">
<p data-cy="mission-statement" class="text--md">{{ mission.statement }}</p>
<v-btn to="/about" block outlined color="white" icon class="btn--sm">
<v-btn block outlined color="white" icon class="btn--sm">
SEE MORE
</v-btn>
</v-col>
Expand Down Expand Up @@ -45,4 +45,7 @@ export default {
max-width: 100%;
max-height: 100%;
}
.content {
padding-top: 50px;
}
</style>
1 change: 1 addition & 0 deletions frontend/src/views/Home/CommunityLink.vue
Original file line number Diff line number Diff line change
Expand Up @@ -138,6 +138,7 @@ export default {
transform: scale(1.05);
}
.content {
padding-top: 50px;
@media screen and (max-width: 960px) {
padding-left: 20px;
padding-right: 20px;
Expand Down
1 change: 1 addition & 0 deletions frontend/src/views/Home/EventDisplay.vue
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,7 @@ export default {
.Container {
display: flex;
flex-direction: row;
padding-top: 50px;
}
.Embed {
display: flex;
Expand Down
3 changes: 3 additions & 0 deletions frontend/src/views/Home/Home.vue
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@

<template>
<div id="home">
<PrimaryNavbar />
<!-- Showcase -->
<Showcase />
<!-- Mission -->
Expand All @@ -39,6 +40,7 @@ import Slideshow from '@/views/Home/Slideshow';
import StudentResources from '@/views/Home/StudentResources';
import SponsorUs from '@/views/Home/SponsorUs';
import APIClient from '../../utils/APIClient';
import PrimaryNavbar from '../../components/PrimaryNavbar';

export default {
name: 'Home',
Expand All @@ -56,6 +58,7 @@ export default {
Slideshow,
StudentResources,
SponsorUs,
PrimaryNavbar,
},
mounted() {
APIClient.eventsAPI()
Expand Down
5 changes: 4 additions & 1 deletion frontend/src/views/Sponsor.vue
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
-->
<template>
<div>
<SecondaryNavbar />
<div class="down-button" @click="onClickScroll" @scroll.passive="handleScroll" ref="downButton">
<img src="@/assets/downbutton.png" />
</div>
Expand Down Expand Up @@ -89,6 +90,7 @@

<script type="text/javascript">
import SponsorModal from '@/components/SponsorModal';
import SecondaryNavbar from '@/components/SecondaryNavbar';

const sponsorData = require('@/assets/sponsors_mini.json');

Expand All @@ -106,7 +108,8 @@ export default {
smallLogoFilter: 5
}),
components: {
SponsorModal
SponsorModal,
SecondaryNavbar
},
computed: {
// functions to determine sizing category of sponsor based on their value
Expand Down