Adding unit tests

Author: pmcmaw

spec/functions/empty_spec.rb

@@ -19,4 +19,21 @@
 
   it { is_expected.to run.with_params({}).and_return(true) }
   it { is_expected.to run.with_params('key' => 'value').and_return(false) }
+
+  context 'with deprecation warning' do
+    after(:each) do
+      ENV.delete('STDLIB_LOG_DEPRECATIONS')
+    end
+    # Checking for deprecation warning, which should only be provoked when the env variable for it is set.
+    it 'displays a single deprecation' do
+      ENV['STDLIB_LOG_DEPRECATIONS'] = 'true'
+      scope.expects(:warning).with(includes('This method is deprecated'))
+      is_expected.to run.with_params(0).and_return(false)
+    end
+    it 'displays no warning for deprecation' do
+      ENV['STDLIB_LOG_DEPRECATIONS'] = 'false'
+      scope.expects(:warning).with(includes('This method is deprecated')).never
+      is_expected.to run.with_params(0).and_return(false)
+    end
+  end
 end

spec/functions/flatten_spec.rb

@@ -1,5 +1,6 @@
 require 'spec_helper'
 
+# rubocop:disable Style/WordArray, Layout/SpaceAfterComma
 describe 'flatten' do
   it { is_expected.not_to eq(nil) }
   it { is_expected.to run.with_params.and_raise_error(Puppet::ParseError) } if Puppet.version < '5.5.0'
@@ -12,4 +13,21 @@
   it { is_expected.to run.with_params(%w[a b c d e f g]).and_return(%w[a b c d e f g]) }
   it { is_expected.to run.with_params([['a', 'b', ['c', %w[d e], 'f', 'g']]]).and_return(%w[a b c d e f g]) }
   it { is_expected.to run.with_params(['ã', 'β', ['ĉ', %w[đ ẽ ƒ ġ]]]).and_return(%w[ã β ĉ đ ẽ ƒ ġ]) }
+
+  context 'with deprecation warning' do
+    after(:each) do
+      ENV.delete('STDLIB_LOG_DEPRECATIONS')
+    end
+    # Checking for deprecation warning, which should only be provoked when the env variable for it is set.
+    it 'displays a single deprecation' do
+      ENV['STDLIB_LOG_DEPRECATIONS'] = 'true'
+      scope.expects(:warning).with(includes('This method is deprecated'))
+      is_expected.to run.with_params(['a', ['b', ['c']]]).and_return(['a','b','c'])
+    end
+    it 'displays no warning for deprecation' do
+      ENV['STDLIB_LOG_DEPRECATIONS'] = 'false'
+      scope.expects(:warning).with(includes('This method is deprecated')).never
+      is_expected.to run.with_params(['a', ['b', ['c']]]).and_return(['a','b','c'])
+    end
+  end
 end

spec/functions/join_spec.rb

@@ -17,4 +17,21 @@
   it { is_expected.to run.with_params(%w[one two three]).and_return('onetwothree') }
   it { is_expected.to run.with_params(%w[one two three], ':').and_return('one:two:three') }
   it { is_expected.to run.with_params(%w[ōŋể ŧשợ ţђŕẽё], ':').and_return('ōŋể:ŧשợ:ţђŕẽё') }
+
+  context 'with deprecation warning' do
+    after(:each) do
+      ENV.delete('STDLIB_LOG_DEPRECATIONS')
+    end
+    # Checking for deprecation warning, which should only be provoked when the env variable for it is set.
+    it 'displays a single deprecation' do
+      ENV['STDLIB_LOG_DEPRECATIONS'] = 'true'
+      scope.expects(:warning).with(includes('This method is deprecated'))
+      is_expected.to run.with_params([]).and_return('')
+    end
+    it 'displays no warning for deprecation' do
+      ENV['STDLIB_LOG_DEPRECATIONS'] = 'false'
+      scope.expects(:warning).with(includes('This method is deprecated')).never
+      is_expected.to run.with_params([]).and_return('')
+    end
+  end
 end

spec/functions/keys_spec.rb

@@ -24,4 +24,21 @@
       expect(result).to match_array(%w[ҝểү キー])
     end
   end
+
+  context 'with deprecation warning' do
+    after(:each) do
+      ENV.delete('STDLIB_LOG_DEPRECATIONS')
+    end
+    # Checking for deprecation warning, which should only be provoked when the env variable for it is set.
+    it 'displays a single deprecation' do
+      ENV['STDLIB_LOG_DEPRECATIONS'] = 'true'
+      scope.expects(:warning).with(includes('This method is deprecated'))
+      is_expected.to run.with_params({}).and_return([])
+    end
+    it 'displays no warning for deprecation' do
+      ENV['STDLIB_LOG_DEPRECATIONS'] = 'false'
+      scope.expects(:warning).with(includes('This method is deprecated')).never
+      is_expected.to run.with_params({}).and_return([])
+    end
+  end
 end

spec/functions/values_spec.rb

@@ -23,4 +23,21 @@
       expect(result).to match_array(['使用', '√ẩŀứệ', '√ẩŀứệ'])
     end
   end
+
+  context 'with deprecation warning' do
+    after(:each) do
+      ENV.delete('STDLIB_LOG_DEPRECATIONS')
+    end
+    # Checking for deprecation warning, which should only be provoked when the env variable for it is set.
+    it 'displays a single deprecation' do
+      ENV['STDLIB_LOG_DEPRECATIONS'] = 'true'
+      scope.expects(:warning).with(includes('This method is deprecated'))
+      is_expected.to run.with_params('key' => 'value').and_return(['value'])
+    end
+    it 'displays no warning for deprecation' do
+      ENV['STDLIB_LOG_DEPRECATIONS'] = 'false'
+      scope.expects(:warning).with(includes('This method is deprecated')).never
+      is_expected.to run.with_params('key' => 'value').and_return(['value'])
+    end
+  end
 end