Skip to content

Update and bug fixes for alignment #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 33 commits into from
Sep 20, 2022
Merged

Update and bug fixes for alignment #15

merged 33 commits into from
Sep 20, 2022

Conversation

cschreib
Copy link
Owner

@cschreib cschreib commented Sep 19, 2022

List of changes in this PR:

  • Fixed enable_observer_from_this* with policies that do not guarantee the existence of a block (i.e., custom policies that are not the default unique or sealed).
  • Fixed leaks for non-sealed pointers, when allocation of the control block fails in the constructor or in reset().
  • Fixed make_observable*() not aware of alignment constraints.
  • Added early static_assert to catch misuse and generate clearer error messages.
  • Various typos fixed, and documentation improved.
  • Speed benchmarks updated.
  • Size benchmarks updated.

@cschreib cschreib changed the title Update and bug fixes Update and bug fixes for alignment Sep 19, 2022
@codecov-commenter
Copy link

codecov-commenter commented Sep 19, 2022

Codecov Report

Merging #15 (bd82372) into main (61b47d5) will not change coverage.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##              main       #15   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines          299       317   +18     
=========================================
+ Hits           299       317   +18     
Impacted Files Coverage Δ
include/oup/observable_unique_ptr.hpp 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 61b47d5...bd82372. Read the comment docs.

@cschreib cschreib merged commit c82b3cd into main Sep 20, 2022
@cschreib cschreib deleted the update branch September 20, 2022 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants