Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable pending formatter features #14718

Merged

Conversation

Blacksmoke16
Copy link
Member

Enables the first batch of ready formatter features as called out in #13002.

NOTE: Depends on #14713

@straight-shoota straight-shoota added this to the 1.13.0 milestone Jun 16, 2024
@straight-shoota
Copy link
Member

straight-shoota commented Jun 17, 2024

I noticed an issue: #14209 and #14075 (partially) are backwards-incompatible changes. Two formatters, one with the changes enabled and one with it disabled, cannot agree on a common accepted style as a valid variant.
This can cause friction related to crystal upgrades, which should be avoidable.

We could ensure a smooth transition by first releasing a version of the formatter which doesn't change old style to new style, but accepts the new style and does not change it back to old style.

For example the change in #12951 is backwards compatible. The current formatter accepts the & style, but doesn't enforce it.

@Blacksmoke16
Copy link
Member Author

Alright, I'll see if I can put something together for that to include in this release. Then can release the part that'll migrate old to new in the next one.

@Blacksmoke16
Copy link
Member Author

CI seems to be failing due to:

docker: Error response from daemon: unauthorized: authentication required.

🤔

@straight-shoota
Copy link
Member

Looks like Docker hub was unavailable... There are some legitimate spec failures though (e.g. https://github.com/crystal-lang/crystal/actions/runs/11023991475/job/30616353981?pr=14718).

@Blacksmoke16
Copy link
Member Author

I figured there would be, discovered #15033 when running the specs locally so figured I'd let CI run while figuring what was going on there.

@straight-shoota straight-shoota added this to the 1.15.0 milestone Oct 4, 2024
@straight-shoota straight-shoota merged commit 991f9d0 into crystal-lang:master Oct 10, 2024
66 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants