-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Error when declaring a constant within another constant declaration #12566
Merged
straight-shoota
merged 7 commits into
crystal-lang:master
from
caspiano:fix/constant-declaration-inception
Nov 16, 2022
Merged
Error when declaring a constant within another constant declaration #12566
straight-shoota
merged 7 commits into
crystal-lang:master
from
caspiano:fix/constant-declaration-inception
Nov 16, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Blacksmoke16
added
kind:bug
A bug in the code. Does not apply to documentation, specs, etc.
topic:compiler:parser
labels
Oct 5, 2022
Does this handle the snippet with the |
@HertzDevil yep, this is caught by the dynamic constant declaration checking. I'll add a test case for it. |
Sija
reviewed
Oct 5, 2022
Co-authored-by: Sijawusz Pur Rahnama <sija@sija.pl>
What happens if the constant assignment is nested in a call? A = puts(B = 1) |
straight-shoota
approved these changes
Oct 10, 2022
sdogruyol
approved these changes
Nov 15, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @caspiano 🙏
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following code will now raise a syntax error, as constants must be declared at the top level or within a type.
Resolves #2874