New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support `Path` for `chdir` arg in `Process` methods #11932

Merged

straight-shoota merged 1 commit into crystal-lang:master from caspiano:fix/process-chdir-path

Apr 28, 2022

Contributor

caspiano commented Mar 26, 2022 •

edited

Loading

Update chdir : String? to chdir : Path | String? in...

Process.new
Process.run
Process.exec

Internally, chdir is passed to Dir.chdir which accepts a Path | String, see this line.


          Support Path for chdir arg in Process methods

55af5bd

Blacksmoke16 added kind:feature topic:stdlib labels

straight-shoota approved these changes

View reviewed changes

oprypin approved these changes

View reviewed changes

beta-ziliani added this to the 1.5.0 milestone

straight-shoota merged commit 22b34c1 into crystal-lang:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind:feature topic:stdlib