Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use type instead of is_a? in filters #10815

Merged
merged 3 commits into from
Jun 21, 2021
Merged

Use type instead of is_a? in filters #10815

merged 3 commits into from
Jun 21, 2021

Conversation

caspiano
Copy link
Contributor

Updates a few instances of .is_a? in use instead of using the type directly in a filter.

HertzDevil
HertzDevil reviewed Jun 12, 2021
View reviewed changes
src/compiler/crystal/semantic/call.cr Outdated Show resolved Hide resolved
src/compiler/crystal/semantic/call_error.cr Outdated Show resolved Hide resolved
@straight-shoota straight-shoota added this to the 1.1.0 milestone Jun 12, 2021
@straight-shoota
Copy link
Member

@caspiano this needs an update

@beta-ziliani beta-ziliani merged commit 71d6e9b into crystal-lang:master Jun 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HertzDevil HertzDevil HertzDevil left review comments

@straight-shoota straight-shoota straight-shoota approved these changes

@oprypin oprypin oprypin approved these changes

Assignees
No one assigned
Labels
kind:refactor topic:stdlib
Projects
None yet
Milestone
1.1.0
Development

Successfully merging this pull request may close these issues.
5 participants
@caspiano @straight-shoota @oprypin @HertzDevil @beta-ziliani