Skip to content

Conversation

@Nadrieril
Copy link
Collaborator

@Nadrieril Nadrieril commented Aug 12, 2024

Bump the version of rustc by 7 weeks, to get the benefits of rust-lang/rust#127028 and rust-lang/rust#128815.

Copy link
Member

@W95Psp W95Psp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
I don't know for GenericParamDefKind 🤔 you're probably right, can you open an issue or something? let's chat about that later and see, this week is a bit too busy :/

@Nadrieril
Copy link
Collaborator Author

We can talk about GenericParamDefKind etc once you start using FullDef for the engine. For now it's not hard to maintain, we can keep it.

@Nadrieril
Copy link
Collaborator Author

Opened #852 to discuss it

@W95Psp
Copy link
Member

W95Psp commented Aug 14, 2024

Great, let's merge then!

@W95Psp W95Psp added this pull request to the merge queue Aug 14, 2024
Merged via the queue into cryspen:main with commit 208fbd6 Aug 14, 2024
@Nadrieril Nadrieril deleted the update-rustc branch August 14, 2024 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants