Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the bot applicable outside of pools by segmenting nodes per investor #3

Open
nymd opened this issue Mar 25, 2022 · 3 comments
Open
Labels
enhancement New feature or request
Milestone

Comments

@nymd
Copy link

nymd commented Mar 25, 2022

Issue: Currently the investors setup is only suitable for pooled nodes given that every node is assumed to be associated with every investor.

For this to be useful to node providers I would suggest two improvements:

  • segregate the nodes to individual investor accounts. Each investor should have a one to many relationship with their own nodes.
  • if we can't pull this info/relationship from a database, I would like to import it via CSV rather than manually load an .env file. CSV import would make it simple for providers to export from their own db.
@lucky-luk3
Copy link
Contributor

Thank you for your proposal nymd.
What you propose makes a lot of sense, we would have to change the data structure to make it more relational and more flexible.
So that the relationship can be:

  • One investor many nodes (personal nodes)
  • Many investors to many nodes (node pools)
  • Many investors individualized to multiple nodes with investor-node relationship (node provider).
node group
da5b851aade23deaa42ab6d02e0790123ddf018f Group1
b82c3fc5a509de8db1961fda913ac4f66a638494 Group1
f87c996a8c6f210f0927dbd8e7506b621e638afd Group2
user role group
user1 investor Group1
user2 investor Group1
user3 admin Group2

To achieve this I think the best way would be grouping users and nodes into groups. In this way we make the node-user relationship more flexible.
@nymd Do you think that this data format could be useful for the case you are considering?
We must make several changes to the way queries and notifications are made to accommodate this data schema.

@ipazc ipazc added this to the v0.1.0 milestone Mar 26, 2022
@ipazc
Copy link
Contributor

ipazc commented Mar 26, 2022

This seems the way to go.

As a temporal workaround while this feature is implemented, N instances of the bot can be executed (not sharing config/database). Each bot can be assigned certain nodes and investors.

@ipazc ipazc added the enhancement New feature or request label Mar 26, 2022
@nymd
Copy link
Author

nymd commented Mar 26, 2022

Looks like it would be flexible enough to support all the different types of node/investor relationships that way, thanks.

@ipazc ipazc modified the milestones: v0.1.0, v0.2.0 Mar 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants