Return fullUpdate from methods it used to (MetaMask#161)

Author: darkwing

index.js

@@ -88,7 +88,7 @@ class KeyringController extends EventEmitter {
 
     await this.createFirstKeyTree();
     this.setUnlocked();
-    this.fullUpdate();
+    return this.fullUpdate();
   }
 
   /**
@@ -182,7 +182,7 @@ class KeyringController extends EventEmitter {
     this.keyrings = await this.unlockKeyrings(password);
 
     this.setUnlocked();
-    this.fullUpdate();
+    return this.fullUpdate();
   }
 
   /**
@@ -203,7 +203,7 @@ class KeyringController extends EventEmitter {
       encryptionSalt,
     );
     this.setUnlocked();
-    this.fullUpdate();
+    return this.fullUpdate();
   }
 
   /**
@@ -330,7 +330,7 @@ class KeyringController extends EventEmitter {
     });
 
     await this.persistAllKeyrings();
-    this.fullUpdate();
+    return this.fullUpdate();
   }
 
   /**
@@ -379,7 +379,7 @@ class KeyringController extends EventEmitter {
     }
 
     await this.persistAllKeyrings();
-    this.fullUpdate();
+    return this.fullUpdate();
   }
 
   //

test/index.js

@@ -99,10 +99,12 @@ describe('KeyringController', function () {
       keyringController.store.updateState({ vault: null });
       assert(!keyringController.store.getState().vault, 'no previous vault');
 
-      await keyringController.createNewVaultAndKeychain(password);
+      const newVault = await keyringController.createNewVaultAndKeychain(
+        password,
+      );
       const { vault } = keyringController.store.getState();
-      // eslint-disable-next-line jest/no-restricted-matchers
-      expect(vault).toBeTruthy();
+      expect(vault).toStrictEqual(expect.stringMatching('.+'));
+      expect(typeof newVault).toBe('object');
     });
 
     it('should unlock the vault', async function () {