Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem: block mode is deprecated, need implement in client side #1103

Merged
merged 4 commits into from
Jul 25, 2023

Conversation

mmsqe
Copy link
Collaborator

@mmsqe mmsqe commented Jul 17, 2023

👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻

PR Checklist:

  • Have you read the CONTRIBUTING.md?
  • Does your PR follow the C4 patch requirements?
  • Have you rebased your work on top of the latest master?
  • Have you checked your code compiles? (make)
  • Have you included tests for any non-trivial functionality?
  • Have you checked your code passes the unit tests? (make test)
  • Have you checked your code formatting is correct? (go fmt)
  • Have you checked your basic code style is fine? (golangci-lint run)
  • If you added any dependencies, have you checked they do not contain any known vulnerabilities? (go list -json -m all | nancy sleuth)
  • If your changes affect the client infrastructure, have you run the integration test?
  • If your changes affect public APIs, does your PR follow the C4 evolution of public contracts?
  • If your code changes public APIs, have you incremented the crate version numbers and documented your changes in the CHANGELOG.md?
  • If you are contributing for the first time, please read the agreement in CONTRIBUTING.md now and add a comment to this pull request stating that your PR is in accordance with the Developer's Certificate of Origin.

Thank you for your code, it's appreciated! :)

@mmsqe mmsqe force-pushed the event_query_tx_for branch from fc87968 to 0d1db5e Compare July 17, 2023 02:20
@mmsqe mmsqe changed the title Problem: broadcast mode is deprecated, need implement block in client side Problem: block mode is deprecated, need implement in client side Jul 17, 2023
x/cronos/client/cli/tx.go Fixed Show fixed Hide fixed
x/cronos/client/cli/tx.go Fixed Show fixed Hide fixed
@mmsqe mmsqe force-pushed the event_query_tx_for branch from 0d1db5e to 0e5210d Compare July 18, 2023 01:35
@mmsqe mmsqe marked this pull request as ready for review July 18, 2023 01:39
@mmsqe mmsqe requested a review from a team as a code owner July 18, 2023 01:39
@mmsqe mmsqe requested review from JayT106 and thomas-nguy and removed request for a team July 18, 2023 01:39
@codecov
Copy link

codecov bot commented Jul 18, 2023

Codecov Report

Merging #1103 (70bcf5e) into main (7461e30) will increase coverage by 24.61%.
The diff coverage is 68.75%.

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #1103       +/-   ##
===========================================
+ Coverage   22.02%   46.64%   +24.61%     
===========================================
  Files          47       81       +34     
  Lines        2996     7280     +4284     
===========================================
+ Hits          660     3396     +2736     
- Misses       2271     3524     +1253     
- Partials       65      360      +295     
Files Changed Coverage Δ
x/cronos/client/cli/tx.go 60.29% <68.75%> (+1.81%) ⬆️

... and 50 files with indirect coverage changes

@mmsqe mmsqe force-pushed the event_query_tx_for branch from ec6a83d to 70bcf5e Compare July 25, 2023 05:43
@mmsqe mmsqe requested a review from yihuang July 25, 2023 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants