Skip to content

Problem: memory leak during memiavl import #1036

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 24, 2023
Merged

Problem: memory leak during memiavl import #1036

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bf71ce5
Problem: memory leak during memiavl import
May 24, 2023
598f5ed
Update CHANGELOG.md
May 24, 2023
e5ac639
Update memiavl/import.go
May 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@

- [#833](https://github.com/crypto-org-chain/cronos/pull/833) Fix rollback command.
- [#945](https://github.com/crypto-org-chain/cronos/pull/945) Fix no handler exists for proposal type error when update-client due to wrong ibc route.
- [#1036](https://github.com/crypto-org-chain/cronos/pull/1036) Fix memiavl import memory leak.

### Improvements

Expand Down
5 changes: 5 additions & 0 deletions memiavl/import.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -200,6 +200,11 @@ func (i *importer) Add(n *iavl.ExportNode) error {
right: rightNode,
}
nodeHash := node.Hash()

// remove unnecessary reference to avoid memory leak
node.left = nil
node.right = nil

preTrees := uint8(len(i.nodeStack) - 2)
if err := i.writeBranch(node.version, uint32(node.size), node.height, preTrees, keyLeaf, nodeHash); err != nil {
return err
Expand Down