Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem: memiavl configs are not defined in app.toml #1028

Merged
merged 4 commits into from
May 15, 2023

Conversation

yihuang
Copy link
Collaborator

@yihuang yihuang commented May 15, 2023

Solution:

  • integrate custom configs into app.toml

👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻

PR Checklist:

  • Have you read the CONTRIBUTING.md?
  • Does your PR follow the C4 patch requirements?
  • Have you rebased your work on top of the latest master?
  • Have you checked your code compiles? (make)
  • Have you included tests for any non-trivial functionality?
  • Have you checked your code passes the unit tests? (make test)
  • Have you checked your code formatting is correct? (go fmt)
  • Have you checked your basic code style is fine? (golangci-lint run)
  • If you added any dependencies, have you checked they do not contain any known vulnerabilities? (go list -json -m all | nancy sleuth)
  • If your changes affect the client infrastructure, have you run the integration test?
  • If your changes affect public APIs, does your PR follow the C4 evolution of public contracts?
  • If your code changes public APIs, have you incremented the crate version numbers and documented your changes in the CHANGELOG.md?
  • If you are contributing for the first time, please read the agreement in CONTRIBUTING.md now and add a comment to this pull request stating that your PR is in accordance with the Developer's Certificate of Origin.

Thank you for your code, it's appreciated! :)

Solution:
- integrate custom configs into app.toml
@yihuang yihuang requested a review from a team as a code owner May 15, 2023 07:33
@yihuang yihuang requested review from mmsqe and calvinaco and removed request for a team May 15, 2023 07:33
CHANGELOG.md Outdated Show resolved Hide resolved
Signed-off-by: yihuang <huang@crypto.com>
@yihuang yihuang added the backport/v1.0.x backport to release/v1.0.x label May 15, 2023
@codecov
Copy link

codecov bot commented May 15, 2023

Codecov Report

Merging #1028 (d5aa5c2) into main (cf9648d) will increase coverage by 0.02%.
The diff coverage is 33.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1028      +/-   ##
==========================================
+ Coverage   45.71%   45.73%   +0.02%     
==========================================
  Files          80       82       +2     
  Lines        6895     6907      +12     
==========================================
+ Hits         3152     3159       +7     
- Misses       3411     3416       +5     
  Partials      332      332              
Impacted Files Coverage Δ
app/memiavl.go 20.00% <20.00%> (ø)
app/config/config.go 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

@yihuang yihuang requested review from mmsqe and removed request for mmsqe May 15, 2023 07:47
app/app.go Outdated Show resolved Hide resolved
app/app.go Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/v1.0.x backport to release/v1.0.x
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants