1414 # see: https://github.com/NixOS/nixpkgs/issues/216479
1515, enableJemalloc ? ! stdenv . hostPlatform . isWindows && ! stdenv . hostPlatform . isStatic
1616, jemalloc
17- , enableLite ? false
1817, enableShared ? ! stdenv . hostPlatform . isStatic
1918, sse42Support ? stdenv . hostPlatform . sse4_2Support
2019} :
2120
22- stdenv . mkDerivation rec {
21+ stdenv . mkDerivation ( finalAttrs : {
2322 pname = "rocksdb" ;
24- version = "8.1.1 " ;
23+ version = "8.11.3 " ;
2524
2625 src = fetchFromGitHub {
2726 owner = "facebook" ;
28- repo = pname ;
29- rev = "v${ version } " ;
30- sha256 = "sha256-79hRtc5QSWLLyjRGCmuYZSoIc9IcIsnl8UCinz2sVw4 =" ;
27+ repo = finalAttrs . pname ;
28+ rev = "v${ finalAttrs . version } " ;
29+ hash = "sha256-OpEiMwGxZuxb9o3RQuSrwZMQGLhe9xLT1aa3HpI4KPs =" ;
3130 } ;
3231
3332 nativeBuildInputs = [ cmake ninja ] ;
@@ -42,16 +41,9 @@ stdenv.mkDerivation rec {
4241 "tools"
4342 ] ;
4443
45- NIX_CFLAGS_COMPILE = lib . optionals stdenv . cc . isGNU [
46- "-Wno-error=deprecated-copy"
47- "-Wno-error=pessimizing-move"
48- # Needed with GCC 12
49- "-Wno-error=format-truncation"
50- "-Wno-error=maybe-uninitialized"
51- ] ++ lib . optionals stdenv . cc . isClang [
52- "-Wno-error=unused-private-field"
44+ env . NIX_CFLAGS_COMPILE = toString ( lib . optionals stdenv . cc . isClang [
5345 "-faligned-allocation"
54- ] ;
46+ ] ) ;
5547
5648 cmakeFlags = [
5749 "-DPORTABLE=1"
@@ -70,18 +62,38 @@ stdenv.mkDerivation rec {
7062 "-DUSE_RTTI=1"
7163 "-DROCKSDB_INSTALL_ON_WINDOWS=YES" # harmless elsewhere
7264 ( lib . optional sse42Support "-DFORCE_SSE42=1" )
73- ( lib . optional enableLite "-DROCKSDB_LITE=1" )
74- "-DFAIL_ON_WARNINGS=${ if stdenv . hostPlatform . isMinGW then "NO" else "YES" } "
65+ "-DFAIL_ON_WARNINGS=NO"
7566 ] ++ lib . optional ( ! enableShared ) "-DROCKSDB_BUILD_SHARED=0" ;
7667
7768 # otherwise "cc1: error: -Wformat-security ignored without -Wformat [-Werror=format-security]"
7869 hardeningDisable = lib . optional stdenv . hostPlatform . isWindows "format" ;
7970
71+ postPatch = lib . optionalString ( lib . versionOlder finalAttrs . version "9" ) ''
72+ # Fix gcc-13 build failures due to missing <cstdint> and
73+ # <system_error> includes, fixed upstream since 9.x
74+ sed -e '1i #include <cstdint>' -i options/offpeak_time_info.h
75+ '' + lib . optionalString ( lib . versionOlder finalAttrs . version "8" ) ''
76+ # Fix gcc-13 build failures due to missing <cstdint> and
77+ # <system_error> includes, fixed upstream since 8.x
78+ sed -e '1i #include <cstdint>' -i db/compaction/compaction_iteration_stats.h
79+ sed -e '1i #include <cstdint>' -i table/block_based/data_block_hash_index.h
80+ sed -e '1i #include <cstdint>' -i util/string_util.h
81+ sed -e '1i #include <cstdint>' -i include/rocksdb/utilities/checkpoint.h
82+ '' + lib . optionalString ( lib . versionOlder finalAttrs . version "7" ) ''
83+ # Fix gcc-13 build failures due to missing <cstdint> and
84+ # <system_error> includes, fixed upstream since 7.x
85+ sed -e '1i #include <system_error>' -i third-party/folly/folly/synchronization/detail/ProxyLockable-inl.h
86+ '' + ''
87+ # fixed in https://github.com/facebook/rocksdb/pull/12309
88+ sed -e 's/ZSTD_INCLUDE_DIRS/zstd_INCLUDE_DIRS/' -i cmake/modules/Findzstd.cmake
89+ sed -e 's/ZSTD_INCLUDE_DIRS/zstd_INCLUDE_DIRS/' -i CMakeLists.txt
90+ '' ;
91+
8092 preInstall = ''
8193 mkdir -p $tools/bin
8294 cp tools/{ldb,sst_dump}${ stdenv . hostPlatform . extensions . executable } $tools/bin/
8395 '' + lib . optionalString stdenv . isDarwin ''
84- ls -1 $tools/bin/* | xargs -I{} ${ stdenv . cc . bintools . targetPrefix } install_name_tool -change "@rpath/librocksdb.${ lib . versions . major version } .dylib" $out/lib/librocksdb.dylib {}
96+ ls -1 $tools/bin/* | xargs -I{} ${ stdenv . cc . bintools . targetPrefix } install_name_tool -change "@rpath/librocksdb.${ lib . versions . major finalAttrs . version } .dylib" $out/lib/librocksdb.dylib {}
8597 '' + lib . optionalString ( stdenv . isLinux && enableShared ) ''
8698 ls -1 $tools/bin/* | xargs -I{} patchelf --set-rpath $out/lib:${ stdenv . cc . cc . lib } /lib {}
8799 '' ;
@@ -94,15 +106,15 @@ stdenv.mkDerivation rec {
94106 fi
95107 '' + lib . optionalString stdenv . isDarwin ''
96108 ${ stdenv . cc . targetPrefix } install_name_tool -change "@rpath/libsnappy.1.dylib" "${ snappy } /lib/libsnappy.1.dylib" $out/lib/librocksdb.dylib
97- ${ stdenv . cc . targetPrefix } install_name_tool -change "@rpath/librocksdb.${ lib . versions . major version } .dylib" "$out/lib/librocksdb.${ lib . versions . major version } .dylib" $out/lib/librocksdb.dylib
109+ ${ stdenv . cc . targetPrefix } install_name_tool -change "@rpath/librocksdb.${ lib . versions . major finalAttrs . version } .dylib" "$out/lib/librocksdb.${ lib . versions . major finalAttrs . version } .dylib" $out/lib/librocksdb.dylib
98110 '' ;
99111
100112 meta = with lib ; {
101113 homepage = "https://rocksdb.org" ;
102114 description = "A library that provides an embeddable, persistent key-value store for fast storage" ;
103- changelog = "https://github.com/facebook/rocksdb/raw/v${ version } /HISTORY.md" ;
115+ changelog = "https://github.com/facebook/rocksdb/raw/v${ finalAttrs . version } /HISTORY.md" ;
104116 license = licenses . asl20 ;
105117 platforms = platforms . all ;
106118 maintainers = with maintainers ; [ adev magenbluten ] ;
107119 } ;
108- }
120+ } )
0 commit comments