Problem: no handler exists for proposal type when update-client (#945) (#958)

Author: mmsqe

CHANGELOG.md

@@ -14,6 +14,7 @@
     - https://github.com/crypto-org-chain/ethermint/pull/233
   - update cosmos-sdk to include one bug fix
     - https://github.com/cosmos/cosmos-sdk/pull/15667
+* [#945](https://github.com/crypto-org-chain/cronos/pull/945) Fix no handler exists for proposal type error when update-client due to wrong ibc route.
 
 *Mar 16, 2023*
 

app/app.go

@@ -100,6 +100,7 @@ import (
 	ibc "github.com/cosmos/ibc-go/v5/modules/core"
 	ibcclient "github.com/cosmos/ibc-go/v5/modules/core/02-client"
 	ibcclientclient "github.com/cosmos/ibc-go/v5/modules/core/02-client/client"
+	ibcclienttypes "github.com/cosmos/ibc-go/v5/modules/core/02-client/types"
 	porttypes "github.com/cosmos/ibc-go/v5/modules/core/05-port/types"
 	ibchost "github.com/cosmos/ibc-go/v5/modules/core/24-host"
 	ibckeeper "github.com/cosmos/ibc-go/v5/modules/core/keeper"
@@ -515,7 +516,7 @@ func New(
 		AddRoute(paramproposal.RouterKey, params.NewParamChangeProposalHandler(app.ParamsKeeper)).
 		AddRoute(distrtypes.RouterKey, distr.NewCommunityPoolSpendProposalHandler(app.DistrKeeper)).
 		AddRoute(upgradetypes.RouterKey, upgrade.NewSoftwareUpgradeProposalHandler(app.UpgradeKeeper)).
-		AddRoute(ibchost.RouterKey, ibcclient.NewClientProposalHandler(app.IBCKeeper.ClientKeeper)).
+		AddRoute(ibcclienttypes.RouterKey, ibcclient.NewClientProposalHandler(app.IBCKeeper.ClientKeeper)).
 		AddRoute(cronostypes.RouterKey, cronos.NewTokenMappingChangeProposalHandler(app.CronosKeeper))
 
 	govConfig := govtypes.DefaultConfig()

integration_tests/cosmoscli.py

@@ -1108,6 +1108,31 @@ def gov_propose_token_mapping_change(
             )
         )
 
+    def gov_propose_update_client_legacy(self, proposal, **kwargs):
+        kwargs.setdefault("gas_prices", DEFAULT_GAS_PRICE)
+        kwargs.setdefault("gas", 600000)
+        return json.loads(
+            self.raw(
+                "tx",
+                "gov",
+                "submit-legacy-proposal",
+                "update-client",
+                proposal.get("subject_client_id"),
+                proposal.get("substitute_client_id"),
+                "-y",
+                from_=proposal.get("from"),
+                keyring_backend="test",
+                # content
+                title=proposal.get("title"),
+                description=proposal.get("description"),
+                deposit=proposal.get("deposit"),
+                chain_id=self.chain_id,
+                home=self.data_dir,
+                stderr=subprocess.DEVNULL,
+                **kwargs,
+            )
+        )
+
     def update_token_mapping(self, denom, contract, symbol, decimals, **kwargs):
         kwargs.setdefault("gas_prices", DEFAULT_GAS_PRICE)
         return json.loads(

integration_tests/test_ibc_update_client.py

@@ -0,0 +1,47 @@
+import subprocess
+import time
+
+import pytest
+
+from .ibc_utils import prepare_network
+
+
+@pytest.fixture(scope="module")
+def ibc(request, tmp_path_factory):
+    "prepare-network"
+    name = "ibc"
+    path = tmp_path_factory.mktemp(name)
+    network = prepare_network(path, name)
+    yield from network
+
+
+def test_ibc_update_client(ibc):
+    """
+    test update expire subject client with new active client
+    """
+    cmd = [
+        "hermes",
+        "--config",
+        ibc.hermes.configpath,
+        "create",
+        "client",
+        "--host-chain",
+        "cronos_777-1",
+        "--reference-chain",
+        "chainmain-1",
+    ]
+    subprocess.check_call(cmd + ["--trusting-period", "1s"])
+    time.sleep(1)
+    subprocess.check_call(cmd)
+    cli = ibc.cronos.cosmos_cli()
+    rsp = cli.gov_propose_update_client_legacy(
+        {
+            "subject_client_id": "07-tendermint-1",
+            "substitute_client_id": "07-tendermint-2",
+            "from": "validator",
+            "title": "update-client-title",
+            "description": "update-client-description",
+            "deposit": "1basetcro",
+        },
+    )
+    assert rsp["code"] == 0, rsp["raw_log"]