Skip to content

Commit 3d537b4

Browse files
committed
Apply suggestions from code review
1 parent 0290926 commit 3d537b4

File tree

2 files changed

+8
-3
lines changed

2 files changed

+8
-3
lines changed

.github/workflows/proto.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -40,10 +40,10 @@ jobs:
4040
with:
4141
PATTERNS: |
4242
**/**.proto
43-
- name: proto-gen
43+
- name: proto-gen-ci
4444
if: env.GIT_DIFF
4545
run: |
46-
make proto-gen # proto-swagger-gen FIXME swagger-gen result is not reproducible in CI
46+
make proto-genci # proto-swagger-gen FIXME swagger-gen result is not reproducible in CI
4747
git checkout -- go.mod go.sum docs/api/proto-docs.md # FIXME doc gen not reproducible in CI
4848
- name: check working directory is clean
4949
uses: numtide/clean-git-action@main

Makefile

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -272,14 +272,19 @@ endif
272272
HTTPS_GIT := https://github.com/crypto-org-chain/cronos.git
273273
protoVer=0.14.0
274274
protoImageName=ghcr.io/cosmos/proto-builder:$(protoVer)
275-
protoImage=$(DOCKER) run --rm -v $(CURDIR):/workspace --workdir /workspace --user root $(protoImageName)
275+
protoImageCi=$(DOCKER) run --rm -v $(CURDIR):/workspace --workdir /workspace --user root $(protoImageName)
276+
protoImage=$(DOCKER) run --rm -v $(CURDIR):/workspace --workdir /workspace $(protoImageName)
276277

277278
# ------
278279
# NOTE: If you are experiencing problems running these commands, try deleting
279280
# the docker images and execute the desired command again.
280281
#
281282
proto-all: proto-format proto-lint proto-gen
282283

284+
proto-gen-ci:
285+
@echo "Generating Protobuf files"
286+
$(protoImageCi) sh ./scripts/protocgen.sh
287+
283288
proto-gen:
284289
@echo "Generating Protobuf files"
285290
$(protoImage) sh ./scripts/protocgen.sh

0 commit comments

Comments
 (0)