Skip to content

Commit 3317719

Browse files
yihuangmmsqe
andauthored
Problem: debug_traceCall is not supported (#1287)
* Problem: debug_traceCall is not supported - add debug_traceCall * Update CHANGELOG.md Signed-off-by: yihuang <huang@crypto.com> * Update CHANGELOG.md Co-authored-by: mmsqe <mavis@crypto.com> Signed-off-by: yihuang <huang@crypto.com> * fix integration test --------- Signed-off-by: yihuang <huang@crypto.com> Co-authored-by: mmsqe <mavis@crypto.com>
1 parent 86ad7b3 commit 3317719

File tree

5 files changed

+20
-12
lines changed

5 files changed

+20
-12
lines changed

CHANGELOG.md

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,14 @@
11
# Changelog
22

3-
*January 2, 2023*
3+
*January 5, 2024*
44

55
## v1.1.0-rc2
66

77
- [#1258](https://github.com/crypto-org-chain/cronos/pull/1258) Support hard-fork style upgrades.
88
- [#1272](https://github.com/crypto-org-chain/cronos/pull/1272) Update ethermint to develop, cosmos-sdk to `v0.47.7`.
99
- [#1273](https://github.com/crypto-org-chain/cronos/pull/1273) Enable push0 opcode in integration test.
1010
- [#1274](https://github.com/crypto-org-chain/cronos/pull/1274) Remove authz module.
11+
- [#1287](https://github.com/crypto-org-chain/cronos/pull/1287) Support debug_traceCall.
1112

1213
### Bug Fixes
1314

go.mod

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -233,7 +233,7 @@ replace (
233233
// TODO: remove it: https://github.com/cosmos/cosmos-sdk/issues/13134
234234
github.com/dgrijalva/jwt-go => github.com/golang-jwt/jwt/v4 v4.4.2
235235
github.com/ethereum/go-ethereum => github.com/crypto-org-chain/go-ethereum v1.10.20-0.20231207063621-43cf32d91c3e
236-
github.com/evmos/ethermint => github.com/crypto-org-chain/ethermint v0.6.1-0.20231222013133-aff52db6631a
236+
github.com/evmos/ethermint => github.com/crypto-org-chain/ethermint v0.6.1-0.20240105065311-ec8d73f585a9
237237
// Fix upstream GHSA-h395-qcrw-5vmq and GHSA-3vp4-m3rf-835h vulnerabilities.
238238
// TODO Remove it: https://github.com/cosmos/cosmos-sdk/issues/10409
239239
github.com/gin-gonic/gin => github.com/gin-gonic/gin v1.9.0

go.sum

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -484,8 +484,8 @@ github.com/crypto-org-chain/cometbft-db v0.0.0-20231011055109-57922ac52a63 h1:R1
484484
github.com/crypto-org-chain/cometbft-db v0.0.0-20231011055109-57922ac52a63/go.mod h1:rocwIfnS+kA060x64gkSIRvWB9StSppIkJuo5MWzL24=
485485
github.com/crypto-org-chain/cosmos-sdk v0.46.0-beta2.0.20240103063449-c887e863fae2 h1:z3LXxlOuRHfRuS6LpA3t9eSaekHmzsdrrDkaXP8UEeU=
486486
github.com/crypto-org-chain/cosmos-sdk v0.46.0-beta2.0.20240103063449-c887e863fae2/go.mod h1:hljXsedSCJYge78hyaMYy+yzDQVGZtKAZBjZn5QMddk=
487-
github.com/crypto-org-chain/ethermint v0.6.1-0.20231222013133-aff52db6631a h1:zvyzrHojL+VkdG80bhHN7ad8s//vXYroW98d5buCWuI=
488-
github.com/crypto-org-chain/ethermint v0.6.1-0.20231222013133-aff52db6631a/go.mod h1:T3Tkhw8XMu8rYObcXpeTqGUaKogS+DKsGPD3ulHN/mg=
487+
github.com/crypto-org-chain/ethermint v0.6.1-0.20240105065311-ec8d73f585a9 h1:GyksSoYaokH0gQoUAWSAWCUe0Dasg9mNDA6RqaVMPeA=
488+
github.com/crypto-org-chain/ethermint v0.6.1-0.20240105065311-ec8d73f585a9/go.mod h1:T3Tkhw8XMu8rYObcXpeTqGUaKogS+DKsGPD3ulHN/mg=
489489
github.com/crypto-org-chain/go-ethereum v1.10.20-0.20231207063621-43cf32d91c3e h1:vnyepPQ/m25+19xcTuBUdRxmltZ/EjVWNqEjhg7Ummk=
490490
github.com/crypto-org-chain/go-ethereum v1.10.20-0.20231207063621-43cf32d91c3e/go.mod h1:+a8pUj1tOyJ2RinsNQD4326YS+leSoKGiG/uVVb0x6Y=
491491
github.com/crypto-org-chain/gravity-bridge/module/v2 v2.0.1-0.20230825054824-75403cd90c6e h1:rSTc35OBjjCBx47rHPWBCIHNGPbMnEj8f7fNcK2TjVI=

gomod2nix.toml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -216,8 +216,8 @@ schema = 3
216216
hash = "sha256-lDIqRLUrXYCb9mmFBY/+WW+ee69+IkxOgqjHVyo4ij0="
217217
replaced = "github.com/crypto-org-chain/go-ethereum"
218218
[mod."github.com/evmos/ethermint"]
219-
version = "v0.6.1-0.20231222013133-aff52db6631a"
220-
hash = "sha256-zmZWMEEhDBVOasR1KzL3uPLNcaKCAlBo0kb4y2B+Qtg="
219+
version = "v0.6.1-0.20240105065311-ec8d73f585a9"
220+
hash = "sha256-7lxGgcTXXRSShErMncDLHtHv+nIbHJ22MMLCo1pqKBg="
221221
replaced = "github.com/crypto-org-chain/ethermint"
222222
[mod."github.com/felixge/httpsnoop"]
223223
version = "v1.0.2"

integration_tests/test_basic.py

Lines changed: 13 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -743,14 +743,21 @@ def test_failed_transfer_tx(cronos):
743743

744744
# check traceTransaction
745745
rsps = [
746-
w3.provider.make_request("debug_traceTransaction", [h.hex()])["result"]
747-
for h in tx_hashes
746+
w3.provider.make_request("debug_traceTransaction", [h.hex()]) for h in tx_hashes
748747
]
749748
for rsp, receipt in zip(rsps, receipts):
750-
# FIXME https://github.com/evmos/ethermint/issues/1185
751-
# trace transaction always return success for simple transfer tx
752-
assert not rsp["failed"]
753-
assert receipt.gasUsed == rsp["gas"]
749+
if receipt.status == 1:
750+
result = rsp["result"]
751+
assert not result["failed"]
752+
assert receipt.gasUsed == result["gas"]
753+
else:
754+
assert rsp["error"] == {
755+
"code": -32000,
756+
"message": (
757+
"rpc error: code = Internal desc = "
758+
"insufficient balance for transfer"
759+
),
760+
}
754761

755762

756763
def test_log0(cluster):

0 commit comments

Comments
 (0)