Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add cosmovisor guide for newtork upgrade #176

Merged
merged 5 commits into from
May 26, 2021

Conversation

allthatjazzleo
Copy link
Contributor

No description provided.

@allthatjazzleo
Copy link
Contributor Author

/staging

docs/getting-started/cosmovisor.md Outdated Show resolved Hide resolved
docs/getting-started/cosmovisor.md Outdated Show resolved Hide resolved
docs/getting-started/cosmovisor.md Outdated Show resolved Hide resolved
allthatjazzleo and others added 2 commits May 26, 2021 08:07
Apply suggestions from code review

Co-authored-by: aw126 <78806365+aw126@users.noreply.github.com>
@allthatjazzleo
Copy link
Contributor Author

/staging

Copy link
Contributor Author

@allthatjazzleo allthatjazzleo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix upgrade time

docs/getting-started/upgrade_guide.md Outdated Show resolved Hide resolved
Copy link
Contributor

@tomtau tomtau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks all right, but perhaps there should be a warning that this is better to be used on full nodes rather than validators -- e.g. currently there's a potential race condition: cosmos/cosmos-sdk#9384

@allthatjazzleo
Copy link
Contributor Author

looks all right, but perhaps there should be a warning that this is better to be used on full nodes rather than validators -- e.g. currently there's a potential race condition: cosmos/cosmos-sdk#9384

added warning

@allthatjazzleo
Copy link
Contributor Author

/staging

Copy link
Collaborator

@lezzokafka lezzokafka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @allthatjazzleo !

@lezzokafka lezzokafka merged commit d274030 into crypto-org-chain:master May 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants