Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Image cleanup job fails to delete the images #644

Closed
tthvo opened this issue Oct 16, 2023 · 7 comments
Closed

[Bug] Image cleanup job fails to delete the images #644

tthvo opened this issue Oct 16, 2023 · 7 comments
Labels
bug Something isn't working ci

Comments

@tthvo
Copy link
Member

tthvo commented Oct 16, 2023

Current Behavior

The clean up job fails to clean images:

finding latest tagged 0 packages matching regex pr-643-ac9929e51df515886d8c3018e8c8af574dd94da9. Also finding latest untagged null packages...
🤓 ignoring missing package error
🔎 found pkgVer pr-643-ac9929e51df515886d8c3018e8c8af574dd94da9...
🔎 tag pr-643-ac9929e51df515886d8c3018e8c8af574dd94da9 matches. VersionId: 137998401. Deleting...

...output-omitted...
1 tagged packages to delete. Keeping top 0...
🔎  1 total packages to delete...
🗑 delete 1 packages
  deleting package cryostatio/cryostat-operator-scorecard:137998401
Error: 🚨 Error ignored - HttpError: Package not found.

Reference: https://github.com/cryostatio/cryostat-operator/actions/runs/6539601137/job/17758248821#step:2:288

Expected Behavior

The images should be found and cleaned up.

Anything else?

image

@tthvo tthvo added the bug Something isn't working label Oct 16, 2023
@tthvo
Copy link
Member Author

tthvo commented Oct 16, 2023

I wonder if this could be due to bump in version of action r26d/ghcr-delete-image-action. This repo uses 1.3.0 while cryostat uses 1.2.2.

Actually, no. This runs uses 1.3.0 and was able to remove the package: https://github.com/cryostatio/cryostat-operator/actions/runs/6125967092/job/16629268806?pr=621

@tthvo tthvo added the ci label Oct 17, 2023
@tthvo
Copy link
Member Author

tthvo commented Oct 17, 2023

This action runs show that packages: write permission is enough to delete package:

https://github.com/cryostatio/cryostat/actions/runs/6500740464/job/17656711095

@tthvo
Copy link
Member Author

tthvo commented Oct 17, 2023

Hey @andrewazores, does this repo has admin access to those packages/images (i.e. cryostat-operator, cryostat-operator-bundle and cryostat-operator-scorecard)? That might be the issue.

https://github.com/cryostatio/cryostat/pull/1635#issuecomment-1700327190

@andrewazores
Copy link
Member

It has write access on each of those.

This action runs show that packages: write permission is enough to delete package:

https://github.com/cryostatio/cryostat/actions/runs/6500740464/job/17656711095

That repo has admin on that package actually, so maybe that is the difference.

image

@tthvo
Copy link
Member Author

tthvo commented Oct 17, 2023

Ahh right. Looks like it needs admin access to delete package as in the screenshot there. I guess this can be closed after switching settings?

@andrewazores
Copy link
Member

I updated the settings already but let's leave this open until we see a CI run successfully clean up after itself.

@tthvo
Copy link
Member Author

tthvo commented Oct 17, 2023

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ci
Projects
No open projects
Status: Done
Development

No branches or pull requests

2 participants