Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use/report relative URLs #735

Open
andrewazores opened this issue Oct 26, 2021 · 0 comments
Open

Use/report relative URLs #735

andrewazores opened this issue Oct 26, 2021 · 0 comments
Labels
breaking change This change (potentially) breaks API compatibility and requires corresponding changes elsewhere feat New feature or request question Further information is requested

Comments

@andrewazores
Copy link
Member

We should investigate if it's possible to remove the various env vars like CRYOSTAT_WEB_HOST, CRYOSTAT_WEB_PORT, CRYOSTAT_SSL_PROXIED - these are all used so that Cryostat can construct authority URLs for itself like https://cryostat.example.com:1234, which are then used to construct URLs for accessing the notifications channel, downloading recordings, or retrieving automated analysis reports. It seems that we should be able to report all of these URLs as simply relative URL paths without the protocol, hostname, port number, and clients should interpret these paths as relative to wherever they are accessing Cryostat from.

This would make the deployment of Cryostat a bit simpler and more flexible.

Also related, can we find a way around having to feed Cryostat the URL for the jfr-datasource and Grafana dashboard?

@andrewazores andrewazores added question Further information is requested breaking change This change (potentially) breaks API compatibility and requires corresponding changes elsewhere feat New feature or request labels Oct 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change This change (potentially) breaks API compatibility and requires corresponding changes elsewhere feat New feature or request question Further information is requested
Projects
None yet
Development

No branches or pull requests

1 participant